Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1295] Change OVERRIDABLE result to WARNING message in package update action #1026

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

pr-watson
Copy link
Contributor

This PR changes an OVERRDIABLE result to a WARNING message in actions/package_updates.py for the case when a failure occurs in checking whether the installed packages on a system are up to date. This is to prevent the previous behavior of inhibiting the conversion when the mentioned check fails.

Jira Issues: RHELC-1295

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96470e9) 94.35% compared to head (a3844d3) 94.34%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
- Coverage   94.35%   94.34%   -0.01%     
==========================================
  Files          47       47              
  Lines        4588     4580       -8     
  Branches      819      818       -1     
==========================================
- Hits         4329     4321       -8     
  Misses        182      182              
  Partials       77       77              
Flag Coverage Δ
centos-linux-7 89.55% <ø> (-0.02%) ⬇️
centos-linux-8 90.54% <ø> (-0.02%) ⬇️
centos-linux-9 90.60% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-watson pr-watson added kind/feature New feature or request tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Jan 8, 2024
@has-bot
Copy link
Member

has-bot commented Jan 8, 2024

/packit test --labels sanity


@oamg/conversions-qe please review results and provide ack.

@Venefilyn
Copy link
Member

Needs a rebase

@pr-watson pr-watson force-pushed the remove-package-update-override branch from 90bfe52 to 2c7bc0c Compare January 23, 2024 14:57
@pr-watson pr-watson force-pushed the remove-package-update-override branch from 2c7bc0c to a3844d3 Compare January 30, 2024 15:00
@pr-watson pr-watson merged commit c76c45e into oamg:main Jan 30, 2024
16 of 57 checks passed
@Venefilyn Venefilyn mentioned this pull request Feb 22, 2024
@bocekm
Copy link
Member

bocekm commented Mar 26, 2024

This PR impacts the https://github.com/oamg/convert2rhel/wiki/Environment-variables. I'll update it now by removing the CONVERT2RHEL_PACKAGE_UP_TO_DATE_CHECK_SKIP from there. Please don't forget to update the wiki with future changes to environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants