[RHELC-1379] Port certs and restorable key to backup module #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
r0x0d
force-pushed
the
port-certs-backup-controller
branch
3 times, most recently
from
26e5789 to
a048f67
Compare
r0x0d
force-pushed
the
port-certs-backup-controller
branch
from
a048f67 to
58532e0
Compare
r0x0d
added
kind/feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 48 48
Lines 4551 4554 +3
Branches 812 812
=======================================
+ Hits 4298 4301 +3
Misses 178 178
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Both the RestorableRpmKey and the PEMCert classes got migrated to their own module inside the backup folder. Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
force-pushed
the
port-certs-backup-controller
branch
from
58532e0 to
7097978
Compare
convert2rhel/unit_tests/actions/pre_ponr_changes/subscription_test.py
Fixed
Show resolved
Hide resolved
pr-watson
approved these changes
Feb 2, 2024
convert2rhel/unit_tests/actions/pre_ponr_changes/subscription_test.py
Fixed
Show resolved
Hide resolved
Signed-off-by: Rodolfo Olivieri <[email protected]>
|
/packit test --labels sanity |
1 similar comment
|
/packit test --labels sanity |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the RestorableRpmKey and the PEMCert classes got migrated to their own module inside the backup folder.
Jira Issues: RHELC-1379
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant