Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1269] Add diagnosis for failures in validating yum transaction #1081

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

pr-watson
Copy link
Contributor

@pr-watson pr-watson commented Feb 6, 2024

This PR adds a diagnosis field for when there is a failure during the validation of a yum transaction. The error raised is added to the diagnosis field which can sometimes come out as a list which is why we have a .join added.

Jira Issues: RHELC-1269

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@pr-watson pr-watson added kind/feature New feature or request tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Feb 6, 2024
@has-bot
Copy link
Member

has-bot commented Feb 6, 2024

/packit test --labels sanity


Comment generated by an automation.

@pr-watson pr-watson force-pushed the update-yum-failure-diagnosis branch from a382dd4 to bece873 Compare February 6, 2024 20:16
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd31177) 94.46% compared to head (8dd569d) 94.46%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1081   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          48       48           
  Lines        4568     4568           
  Branches      815      815           
=======================================
  Hits         4315     4315           
  Misses        178      178           
  Partials       75       75           
Flag Coverage Δ
centos-linux-7 89.66% <ø> (ø)
centos-linux-8 90.65% <ø> (ø)
centos-linux-9 90.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-watson pr-watson force-pushed the update-yum-failure-diagnosis branch from bece873 to 274b488 Compare February 14, 2024 21:22
@Venefilyn
Copy link
Member

Unit tests failing

@pr-watson pr-watson force-pushed the update-yum-failure-diagnosis branch from 274b488 to 8dd569d Compare February 15, 2024 14:11
@pr-watson pr-watson merged commit dd54f1d into oamg:main Feb 16, 2024
19 of 59 checks passed
@Venefilyn Venefilyn mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants