Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remediation spacing in IsLoadedKernelLatest action #1104

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Feb 20, 2024

The remediation was missing a newline at the end of it to separate the steps to follow and the env var message.

Jira Issues: RHELC-

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

The remediation was missing a newline at the end of it to separate the
steps to follow and the env var message.

Signed-off-by: Rodolfo Olivieri <[email protected]>
@r0x0d r0x0d added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run. labels Feb 20, 2024
@r0x0d r0x0d requested a review from Venefilyn February 20, 2024 18:30
@has-bot
Copy link
Member

has-bot commented Feb 20, 2024

This PR does not require integration tests to be run.


Comment generated by an automation.

@r0x0d
Copy link
Member Author

r0x0d commented Feb 20, 2024

How the message is presented right now:

========== Overridable (Review and either fix or ignore the failure) ==========

(OVERRIDABLE) IS_LOADED_KERNEL_LATEST::INVALID_KERNEL_VERSION - Invalid kernel

    version detected

     Description: The loaded kernel version mismatch the latest one available in

the enabled system repositories

     Diagnosis: The version of the loaded kernel is different from the latest

version in the enabled system repositories.

     Latest kernel version available in

Satellite_Engineering_Rocky_Linux_8_BaseOS_8_latest_x86_64:

4.18.0-513.11.1.el8_9

     Loaded kernel version: 4.18.0-513.11.1.el8_9.0.1

     Remediations: To proceed with the conversion, update the kernel version by

executing the following step:



    1. yum install kernel-core-4.18.0-513.11.1.el8_9 -y

    2. rebootIf you wish to ignore this message, set the environment variable

'CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK' to 1.

@r0x0d r0x0d requested a review from pr-watson February 20, 2024 18:31
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b08cc6) 94.89% compared to head (0263aeb) 94.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1104   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files          49       49           
  Lines        4549     4549           
  Branches      809      809           
=======================================
  Hits         4317     4317           
  Misses        156      156           
  Partials       76       76           
Flag Coverage Δ
centos-linux-7 90.08% <ø> (ø)
centos-linux-8 91.08% <ø> (ø)
centos-linux-9 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d enabled auto-merge (squash) February 20, 2024 19:00
@r0x0d r0x0d merged commit d54f193 into oamg:main Feb 20, 2024
23 of 63 checks passed
@r0x0d r0x0d deleted the update-result-message branch February 21, 2024 02:04
jochapma pushed a commit to jochapma/convert2rhel that referenced this pull request Mar 11, 2024
The remediation was missing a newline at the end of it to separate the
steps to follow and the env var message.

Signed-off-by: Rodolfo Olivieri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants