Use YumBase instead of YumBaseCli to get pkg updates #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #495 +/- ##
==========================================
+ Coverage 82.10% 82.11% +0.01%
==========================================
Files 16 16
Lines 2235 2231 -4
Branches 379 378 -1
==========================================
- Hits 1835 1832 -3
Misses 333 333
+ Partials 67 66 -1
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging 29e8058 into 68bf0ac - view on LGTM.com new alerts:
|
abadger
previously approved these changes
May 13, 2022
r0x0d
requested changes
May 13, 2022
bocekm
force-pushed
the
do_not_use_yumbasecli_to_fix_logging
branch
from
29e8058 to
905dc2c
Compare
|
This pull request introduces 1 alert when merging 905dc2c into 68bf0ac - view on LGTM.com new alerts:
|
YumBaseCli was causing the logging of convert2rhel to be broken - after instantiating YumBaseCli every log message was duplicate on the output. The reason is that initialization of the YumBaseCli class instance includes calling logging.basicConfig() which sets up handlers on the root logger. It is possible to use the YumBase class, which does not affect logging, to get the same data - list of packages having updates available. The YumBaseCli logging handlers interfered with the convert2rhel logging as we use propage=True to be able to use caplog in our unit tests: oamg#179
bocekm
force-pushed
the
do_not_use_yumbasecli_to_fix_logging
branch
from
905dc2c to
0f5c08c
Compare
|
This pull request introduces 1 alert when merging 0f5c08c into 68bf0ac - view on LGTM.com new alerts:
|
r0x0d
approved these changes
May 13, 2022
abadger
approved these changes
May 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using YumBaseCli caused doubling of every log message on the output.
The reason is that instantiating of the YumBaseCli class includes calling logging.basicConfig() which sets up handlers on the root logger.
The YumBaseCli logging handlers interfered with the convert2rhel logging as we use propage=True to be able to use caplog in our unit tests:
#179
It is possible to use the YumBase class, which does not affect logging, to get the same data - list of packages having updates available.