Improve logging of the rhsm registration #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 17 17
Lines 2400 2400
Branches 416 416
=======================================
Hits 2100 2100
Misses 239 239
Partials 61 61 Continue to review full report at Codecov.
|
bocekm
changed the title
bocekm
force-pushed
the
improve-rhsm-registration-logging
branch
from
29aed4b to
1c516ba
Compare
r0x0d
approved these changes
May 27, 2022
r0x0d
previously approved these changes
May 27, 2022
|
Just FYI, the slight decrease of codecov coverage is because this PR is removing some piece of code, that before, used to be covered. |
|
/packit test |
In a case where the system registration using --org and --activationkey failed, the logging message "Trying again - provide username and password." didn't make sense because we're not asking in that case for a username and a password.
bocekm
force-pushed
the
improve-rhsm-registration-logging
branch
from
1c516ba to
7f66e38
Compare
r0x0d
approved these changes
Jun 7, 2022
|
/packit test |
1 similar comment
|
/packit test |
r0x0d
pushed a commit
to r0x0d/convert2rhel
that referenced
this pull request
Jun 14, 2022
In a case where the system registration using --org and --activationkey failed, the logging message "Trying again - provide username and password." didn't make sense because we're not asking in that case for a username and a password.
Andrew-ang9
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Jun 17, 2022
In a case where the system registration using --org and --activationkey failed, the logging message "Trying again - provide username and password." didn't make sense because we're not asking in that case for a username and a password.
abadger
pushed a commit
to hosekadam/convert2rhel
that referenced
this pull request
Jun 28, 2022
In a case where the system registration using --org and --activationkey failed, the logging message "Trying again - provide username and password." didn't make sense because we're not asking in that case for a username and a password.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a case where the system registration using --org and --activationkey failed, the logging message "Trying again - provide username and password." didn't make sense because we're not asking in that case for a username and a password.
Also I moved printing the "Gathering subscription-manager registration info" to be under the "Attempt 2 of 3: Registering" because the info gathering is actually already part of the next attempt.
Original output:
New output: