-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHELC-642] Add integration test that install custom kernel #529
Conversation
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 17 17
Lines 2392 2392
Branches 414 414
=======================================
Hits 2092 2092
Misses 239 239
Partials 61 61 Continue to review full report at Codecov.
|
/packit build |
Once the https://issues.redhat.com/browse/RHELC-642 is resolved we can re-run the tests |
|
||
|
||
def test_custom_kernel(convert2rhel): | ||
# Run c2r with --variant option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Run c2r with --variant option | |
# Run c2r with --variant option |
Isn't this a copy paste error?
shell( | ||
"yum install https://yum.oracle.com/repo/OracleLinux/OL7/UEKR6/x86_64/getPackage/kernel-uek-5.4.17-2011.0.7.el7uek.x86_64.rpm -y" | ||
).returncode | ||
== 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kokesak does this still work? Because we have a check in Convert2RHEL to prevent UEK kernels to pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r0x0d if the check works, then the conversion should inhibit. We can keep the UEK kernel install here as well as add a scenario where the non-uek kernel is installed on centos to test that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right... I'm having some troubles to reproduce this locally because of those checks. Do you have a step-by-step on how to do it?
Tried with the UEK and then the conversion halts on that check. Tried OL7 kernel, but it is the same version of CentOS 7 (no downgrades available for both of them)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe I had similar problem when installing OL7 kernel on CentOS so I used the UEK. I'll try it and let you know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I tried to follow the steps in this test, but didn't work because of the checks we have in place for UEK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kokesak tried with this one and it worked: https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/getPackage/kernel-3.10.0-1160.76.1.0.1.el7.x86_64.rpm
Maybe we can adapt the test to include this kernel instead of the UEK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, @kokesak, do you want to merge this PR with mine, so we get everything in one place?
I can cherry-pick your changes here and merge into mine if you think that is worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r0x0d nice that it works. It will be nice to have it under the same PR. I will add the commit to your PR myself and close this one, you dont have to do it.
@kokesak since we merged this in the PR#623, can we close this one? |
@r0x0d yeah sure, closing this one |
Install custom kernel on the system that is not signed by the running OS and verify that the system inhibits/reports warning.
Tickets that are little bit related to this: #389, #424
Bug found: https://issues.redhat.com/browse/RHELC-642