Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-642] Add integration test that install custom kernel #529

Closed
wants to merge 1 commit into from

Conversation

kokesak
Copy link
Member

@kokesak kokesak commented Jun 23, 2022

Install custom kernel on the system that is not signed by the running OS and verify that the system inhibits/reports warning.

Tickets that are little bit related to this: #389, #424

Bug found: https://issues.redhat.com/browse/RHELC-642

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #529 (d0c70c8) into main (7e45e34) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files          17       17           
  Lines        2392     2392           
  Branches      414      414           
=======================================
  Hits         2092     2092           
  Misses        239      239           
  Partials       61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e45e34...d0c70c8. Read the comment docs.

@bocekm
Copy link
Member

bocekm commented Jun 24, 2022

/packit build

@kokesak
Copy link
Member Author

kokesak commented Jun 27, 2022

Once the https://issues.redhat.com/browse/RHELC-642 is resolved we can re-run the tests

@bocekm bocekm added the blocked label Jul 4, 2022


def test_custom_kernel(convert2rhel):
# Run c2r with --variant option
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Run c2r with --variant option
# Run c2r with --variant option

Isn't this a copy paste error?

Comment on lines +20 to +23
shell(
"yum install https://yum.oracle.com/repo/OracleLinux/OL7/UEKR6/x86_64/getPackage/kernel-uek-5.4.17-2011.0.7.el7uek.x86_64.rpm -y"
).returncode
== 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kokesak does this still work? Because we have a check in Convert2RHEL to prevent UEK kernels to pass

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r0x0d if the check works, then the conversion should inhibit. We can keep the UEK kernel install here as well as add a scenario where the non-uek kernel is installed on centos to test that as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... I'm having some troubles to reproduce this locally because of those checks. Do you have a step-by-step on how to do it?

Tried with the UEK and then the conversion halts on that check. Tried OL7 kernel, but it is the same version of CentOS 7 (no downgrades available for both of them)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe I had similar problem when installing OL7 kernel on CentOS so I used the UEK. I'll try it and let you know

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I tried to follow the steps in this test, but didn't work because of the checks we have in place for UEK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kokesak tried with this one and it worked: https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/getPackage/kernel-3.10.0-1160.76.1.0.1.el7.x86_64.rpm

Maybe we can adapt the test to include this kernel instead of the UEK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, @kokesak, do you want to merge this PR with mine, so we get everything in one place?

I can cherry-pick your changes here and merge into mine if you think that is worth it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r0x0d nice that it works. It will be nice to have it under the same PR. I will add the commit to your PR myself and close this one, you dont have to do it.

@Venefilyn Venefilyn changed the title Add integration test that install custom kernel [RHELC-642] Add integration test that install custom kernel Oct 4, 2022
@r0x0d
Copy link
Member

r0x0d commented Oct 31, 2022

@kokesak since we merged this in the PR#623, can we close this one?

@kokesak
Copy link
Member Author

kokesak commented Oct 31, 2022

@r0x0d yeah sure, closing this one

@kokesak kokesak closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants