Playbook fixes #534
Merged
Playbook fixes #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in oamg#532, the logic in the ansible playbook was to fail when either the version check showed an unhandled version OR the skip_os_version_check was set to true. This meant that the toggle would either check the version or the playbook will fail. By using AND in that logic, we get the behaviour we want. Either the toggle will check the version or the playbook's check will succeed It is confusing because it is a `fail:` task. So a true value in the conditional WILL fail the playbook while a false value in the conditional means that the playbook WILL NOT fail here. Fixes oamg#532
Codecov Report
@@ Coverage Diff @@
## main #534 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 17 17
Lines 2392 2392
Branches 414 414
=======================================
Hits 2092 2092
Misses 239 239
Partials 61 61 Continue to review full report at Codecov.
|
|
note: The ansible playbooks are not shipped in the rpms to customers so this change does not need an integration test and does not appear in the release notes. |
r0x0d
approved these changes
Jul 4, 2022
|
Thanks, @abadger, for the quick fix on this. |
danmyway
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Jul 12, 2022
* Fix setup playbook feature allowing user to skip os version check. As reported in oamg#532, the logic in the ansible playbook was to fail when either the version check showed an unhandled version OR the skip_os_version_check was set to true. This meant that the toggle would either check the version or the playbook will fail. By using AND in that logic, we get the behaviour we want. Either the toggle will check the version or the playbook's check will succeed It is confusing because it is a `fail:` task. So a true value in the conditional WILL fail the playbook while a false value in the conditional means that the playbook WILL NOT fail here. Fixes oamg#532 * Fix syntax of looping over centos8_repos. As reported in oamg#533, the loop syntax we have in the ansible playbook is not quite right. Instead of simply writing the variable name as we have it now, we are responsible for asking for it to be expanded in the loop construct (using "{{ }}"). Fixes oamg#533
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two playbook issues. These issues prevented the ansible playbook from converting centos machines. People could still run convert2rhel from the command line.
Fix syntax of looping over centos8_repos. As reported in Invalid data passed to loop in setup-convert2rhel #533, the loop syntax we have in the ansible playbook is
not quite right. Instead of simply writing the variable name as we have it now, we are responsible for asking for it to be expanded in the loop construct (using "{{ }}").
Fixes Invalid data passed to loop in setup-convert2rhel #533
Fix setup playbook feature allowing user to skip os version check. As reported in Incorrect logic in setup-convert2rhel.yml when skip_os_version_check is true #532, the logic in the ansible playbook was to fail when either the version check showed an unhandled version OR the skip_os_version_check was set to true. This meant that the toggle would either check the version or the playbook will fail.
By using AND in that logic, we get the behaviour we want. Either the toggle will check the version or the playbook's check will succeed
It is confusing because it is a
fail:task. So a true value in the conditional WILL fail the playbook while a false value in the conditional means that the playbook WILL NOT fail here.Fixes Incorrect logic in setup-convert2rhel.yml when skip_os_version_check is true #532
https://issues.redhat.com/browse/RHELC-650