[RHELC-670] Clean up new version check #566
Conversation
Andrew-ang9
force-pushed
the
clean_up_PR_415
branch
from
ea5f880 to
356a5af
Compare
Andrew-ang9
force-pushed
the
clean_up_PR_415
branch
from
c01ee05 to
672c16b
Compare
Codecov ReportBase: 93.30% // Head: 93.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 93.30% 93.41% +0.11%
==========================================
Files 22 22
Lines 3107 3115 +8
Branches 552 553 +1
==========================================
+ Hits 2899 2910 +11
+ Misses 144 143 -1
+ Partials 64 62 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
I made a couple of suggestions here, but other than that, it looks super good! Also, it's valid to mention that not all suggestions I made need to be applied if you don't think that they don't make sense. None of them were critical, just improvements to the text or style.
Good progress with that PR, @Andrew-ang9!
|
This pull request introduces 2 alerts and fixes 1 when merging 41e0a2f into 4add545 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging 9753b09 into 4add545 - view on LGTM.com fixed alerts:
|
Andrew-ang9
force-pushed
the
clean_up_PR_415
branch
from
9753b09 to
13d74b0
Compare
|
This pull request fixes 1 alert when merging 13d74b0 into 908f9d5 - view on LGTM.com fixed alerts:
|
Andrew-ang9
force-pushed
the
clean_up_PR_415
branch
from
13d74b0 to
4f7fcf9
Compare
|
This pull request fixes 1 alert when merging 4f7fcf9 into 35eb8f0 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
A few changes, mostly regarding logging, typos, and rewording. But also one about restoring a deleted code section - I admit the acceptance criteria in the issue was a bit confusing with this but it wasn't about removing the section but about preventing bloat by checking internet access in the beginning of the check
Andrew-ang9
force-pushed
the
clean_up_PR_415
branch
from
4f7fcf9 to
504b117
Compare
|
This pull request fixes 1 alert when merging 504b117 into 26cc4fe - view on LGTM.com fixed alerts:
|
|
Your git-forge project |
|
This pull request fixes 1 alert when merging b49bb23 into 26cc4fe - view on LGTM.com fixed alerts:
|
|
Your git-forge project |
|
This pull request introduces 1 alert and fixes 1 when merging 5de0181 into 23c132f - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging 73d9369 into 23c132f - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 3bfe512 into ba02486 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 6d5c9bc into d233bd7 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging f60be9f into 321a3ee - view on LGTM.com fixed alerts:
|
Andrew-ang9
force-pushed
the
clean_up_PR_415
branch
from
f60be9f to
767c1b5
Compare
|
This pull request fixes 1 alert when merging 767c1b5 into 321a3ee - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging b903bf7 into 9a7f103 - view on LGTM.com fixed alerts:
|
|
/packit test |
|
This pull request fixes 1 alert when merging 00a8add into 8f544df - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging ffe33b6 into 20e7ad4 - view on LGTM.com fixed alerts:
|
* Changed the gpg_keys var name to fit better * Fixes typos in some of the logging messages * Got rid of the two imports that are not used * Added the check to see if the c2r is the latest * Removed the debug comments that where in ther code * Moved a constant var to the module level * Fixed a typo in the "cmd" var * changed the unit test to handle differnt major ver * Update debug log message to clarify this is about an internal variable, not about the packages on the system. * Rename environment variable * Update log messages that use the CONVERT2RHEL_UNSUPPORTED_VERSION to use the new name: CONVERT2RHEL_ALLOW_OLDER_VERSION * Fix tests for new environment variable name * Switch from --repofrom to a repofile set by --setopt. Turning on proper ssl certificate checking using --setopt works on RHEL8 (dnf) but doesn't work on RHEL7 (yum) so we have to use a repo file. Co-authored-by: Michal Bocek <[email protected]>
abadger
force-pushed
the
clean_up_PR_415
branch
from
ffe33b6 to
3aec41a
Compare
Venefilyn
dismissed stale reviews from bocekm and r0x0d
Addressed and verified
Co-authored-by: Michal Bocek <[email protected]> Co-authored-by: Toshio Kuratomi <[email protected]>
This PR was made to clean up PR #415, which was merged without taking care of some of the other comments that were left on the PR. Those comments weren't vital enough to stop the PR from being merged.
All comments have been put in the Jira ticket and addressed for the first commit of this PR.
Jira ticket: RHELC-670