[RHELC-708] Check if shim-x64 package is present in the system

[r0x0d]

In PR #553 we removed a condition from the shim-x64 special case workaround
where it was only supposed to handle UEFI systems, and now we are handling BIOS
as well. The problem is that in the BIOS systems, this package may not be
installed at all.

This commit introduces a quick check to validate if the package is present on
the system before trying to backup it's protection file under
/etc/yum/protected.d.

Signed-off-by: Rodolfo Olivieri [email protected]

[codecov]

Codecov Report

Merging #572 (785ecf3) into main (4add545) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   91.49%   91.50%   +0.01%     
==========================================
  Files          18       18              
  Lines        2715     2719       +4     
  Branches      489      490       +1     
==========================================
+ Hits         2484     2488       +4     
  Misses        172      172              
  Partials       59       59              

Impacted Files	Coverage Δ
convert2rhel/special_cases.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[danmyway]

Do we want to have a sanity check for this one @r0x0d, @bocekm ?

[r0x0d]

A sanity check in this case would mean (not) having the shim-x64 package installed prior to the conversion, right? Well, I think that since we run the tests on BIOS only for now, I would say that it could be good thing to have.

This problem occurs because on BIOS, the package might not be installed at all, and this was a leftover mistake from my previous PR that I did not handle that properly...

[danmyway]

That is exactly what I had in mind.
I will take care of that.

[abadger]

This looks good. The main change is just adding a single condition to perform the action only when the shim-x64 package is installed.

+1

[Venefilyn]

@r0x0d @bocekm did we have a Jira issue for this?

[bocekm]

@SpyTec, it's a follow up to https://issues.redhat.com/browse/RHELC-708 and its fix #553. After we merged it I spotted the implementation is incomplete and I mentioned it here: #553 (comment).

Technically, there's no issue to this follow up bug fix. Even though I think it can be considered as part of the https://issues.redhat.com/browse/RHELC-708. But feel free to create a separate issue for this.