[RHELC-760] Increase the line length in a pseudo-terminal #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the rpm we download during a package backup can be so long that the length of the line of 120 characters we set in the pseudo-terminal may not be sufficient. Real world example of a truncated rpm name: libvirt-daemon-driver-storage-core-8.0.0-5.4.0.1.module+el8.6.0+20743+999ad699.x86_64.r 326 kB/s | 253 kB 00:00
Codecov ReportBase: 91.51% // Head: 91.51% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 18 18
Lines 2723 2723
Branches 492 492
=======================================
Hits 2492 2492
Misses 172 172
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This seems like a bug fix so I would still create a Jira issue for it. @bocekm could you create one for Q4 with Story point of 1 in that case? It relates to the codebase in some way so it is always good to document what we've done |
r0x0d
approved these changes
Oct 10, 2022
bocekm
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the rpm we download during a package backup can be so long that the length of the line of 120 characters we set in the pseudo-terminal may not be sufficient. If the downloaded package file name (NEVRA.rpm) is too long, the yumdownloader truncates it and then our output parsing fails. That leads to not tracking the downloaded package and, more importantly, not installing the package back during a rollback.
Real world example of a truncated rpm name:
libvirt-daemon-driver-storage-core-8.0.0-5.4.0.1.module+el8.6.0+20743+999ad699.x86_64.r 326 kB/s | 253 kB 00:00Jira Issue: RHELC-760
Checklist
[RHELC-]is part of the PR titleRelease Pending