Add a few exceptions class for yum transaction handler #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We discovered that we were missing a few exception classes to catch during the package download. We went ahead and added a couple of exceptions to catch gpg checks and mirror exceptions too. Signed-off-by: Rodolfo Olivieri <[email protected]>
Codecov ReportBase: 93.47% // Head: 93.47% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 22 22
Lines 3188 3188
Branches 568 568
=======================================
Hits 2980 2980
Misses 146 146
Partials 62 62
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abadger
reviewed
Nov 29, 2022
abadger
reviewed
Nov 29, 2022
Signed-off-by: Rodolfo Olivieri <[email protected]>
Venefilyn
reviewed
Nov 29, 2022
Venefilyn
approved these changes
Nov 29, 2022
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Dec 6, 2022
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
7 tasks
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Dec 6, 2022
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
abadger
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Dec 7, 2022
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Jan 2, 2023
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Jan 12, 2023
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Feb 6, 2023
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Feb 9, 2023
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Feb 13, 2023
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Feb 14, 2023
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Feb 14, 2023
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
added a commit
to r0x0d/convert2rhel
that referenced
this pull request
Feb 14, 2023
While testing convert2rhel manually in a vagrant box, I realized that the conversion stopped in the yum transaction validation phase, generating a traceback and not doing a proper rollback after the error appeared. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of oamg#674 that introduced the fix, we left out the integration tests that were supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]>
bocekm
added a commit
that referenced
this pull request
Feb 16, 2023
…677) * Add missing integration tests for single yum transaction While testing convert2rhel manually in a vagrant box, we've bumped into a traceback when the conversion stopped in the yum transaction validation phase and no rollback happened. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of #674 that introduced a fix for that, we left out the integration test that was supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]> Co-authored-by: Michal Bocek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Venefilyn
pushed a commit
that referenced
this pull request
Jun 19, 2023
Venefilyn
pushed a commit
that referenced
this pull request
Jun 19, 2023
…677) * Add missing integration tests for single yum transaction While testing convert2rhel manually in a vagrant box, we've bumped into a traceback when the conversion stopped in the yum transaction validation phase and no rollback happened. Since the transaction validation is supposed to trigger the rollback in case of any failures, it was strange that the tool was not behaving the way it should. As part of #674 that introduced a fix for that, we left out the integration test that was supposed to cover this scenario. Signed-off-by: Rodolfo Olivieri <[email protected]> Co-authored-by: Michal Bocek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that we were missing a few exception classes to catch during the package download. We went ahead and added a couple of exceptions to catch gpg checks and mirror exceptions too.
Signed-off-by: Rodolfo Olivieri [email protected]
Jira Issue: RHELC-
Checklist
[RHELC-]is part of the PR titleRelease Pending