[RHELC-892] Fix duplicate setting of locale #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we created `initialize.set_locale()`, removing the function from its former location in `utils.py` was missed. Subsequently, some new code was added to `utils.set_locale()` when it should have been added to `initialize` instead. This commit merges the new changes into `initialize.set_locale()` and finishes the move by removing the duplicate from `utils.py`. Fixes RHELC-892
Codecov ReportBase: 92.36% // Head: 92.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
+ Coverage 92.36% 92.38% +0.02%
==========================================
Files 22 22
Lines 3194 3193 -1
Branches 562 562
==========================================
Hits 2950 2950
+ Misses 175 174 -1
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/packit retest-failed |
Venefilyn
approved these changes
Feb 7, 2023
Merged
bocekm
changed the title
bocekm
changed the title
Venefilyn
changed the title
Venefilyn
pushed a commit
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we created
initialize.set_locale()under #528, removing the function from its former location inutils.pywas missed. Subsequently, some new code was added toutils.set_locale()under #615 when it should have been added toinitializeinstead. This commit merges the new changes intoinitialize.set_locale()and finishes the move by removing the duplicate fromutils.py.Jira Issue: RHELC-892
Checklist
[RHELC-]is part of the PR titleRelease Pending