Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHELC-891] Use https instead of http in the internet connection check #736

Merged
merged 1 commit into from
Feb 9, 2023
Merged

[RHELC-891] Use https instead of http in the internet connection check #736

merged 1 commit into from
Feb 9, 2023

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Feb 9, 2023 •
edited
Loading

Changed the internet connection address to use https instead of http, as it could cause problems under firewalls that blocks http requests.

Signed-off-by: Rodolfo Olivieri [email protected]

Jira Issue: RHELC-891

Checklist

  • PR meets acceptance criteria specified in the Jira issue
  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending

@r0x0d r0x0d requested a review from bocekm February 9, 2023 19:43
@r0x0d r0x0d self-assigned this Feb 9, 2023
@r0x0d
Update internet connection check address
da470e8 
Changed the internet connection address to use https instead of http, as
it could cause problems under firewalls that blocks http requests.

Signed-off-by: Rodolfo Olivieri <[email protected]>
@r0x0d r0x0d force-pushed the change-internet-connection-address-to-https branch from 023aa25 to da470e8 Compare February 9, 2023 19:44
@Venefilyn Venefilyn added this pull request to the merge queue Feb 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 9, 2023
@Venefilyn Venefilyn added this pull request to the merge queue Feb 9, 2023
@Venefilyn Venefilyn removed this pull request from the merge queue due to the queue being cleared Feb 9, 2023
@Venefilyn Venefilyn merged commit 54c797c into oamg:main Feb 9, 2023
vipmike007
vipmike007 reviewed Feb 10, 2023
View reviewed changes
Copy link

@vipmike007 vipmike007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code comment under def _check_internet_access() still mentioned http instead of https, it should be modified as well

Mike

@r0x0d r0x0d deleted the change-internet-connection-address-to-https branch February 10, 2023 01:32
@r0x0d
Copy link
Member Author

r0x0d commented Feb 10, 2023

The code comment under def _check_internet_access() still mentioned http instead of https, it should be modified as well

Mike

Thanks for spotting that out. I will open a follow-up PR to fix that comment.

@Venefilyn Venefilyn added the kind/bug-fix A bug has been fixed label Feb 13, 2023
@Venefilyn Venefilyn mentioned this pull request Feb 20, 2023
Merged
@Venefilyn Venefilyn changed the title [RHELC-891] Update internet connection check address [RHELC-891] Use https instead of http in the internet connection check Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipmike007 vipmike007 vipmike007 left review comments

@bocekm bocekm bocekm approved these changes

@Venefilyn Venefilyn Venefilyn approved these changes

Assignees

@r0x0d r0x0d

Labels
kind/bug-fix A bug has been fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r0x0d @vipmike007 @Venefilyn @bocekm