[RHELC-752] Fix "missing boot files" test #748
Conversation
Codecov ReportBase: 92.82% // Head: 92.82% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 24 24
Lines 3316 3316
Branches 580 580
=======================================
Hits 3078 3078
Misses 171 171
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
On CentOS and Oracle Linux 7 the test was failing because we were renaming the vmlinuz and initramfs files in order to back them up, but we left them in the /boot/ folder. That caused the grub2-mkconfig to pick them up and generated a new grub configuration using these renamed boot files. This change does not back up the boot files but instead simply removes them, simulating better the core test scenario of this integration test which is the kernel rpm scriptlet failure to copy/generate these boot files. After verifying that convert2rhel detected this situation of missing boot files correctly, the test goes on to do what the user instructed to do in such a case - that is reinstalling the kernel and re-runing grub2-mkconfig. Fixes oamg#721.
bocekm
force-pushed
the
fix-missing-kernel-boot-files-test
branch
from
9ee2990 to
b5812f7
Compare
|
The Oracle Linux 7.9 Given there was just one file modified, there is no risk in merging, when the pipelines above finish and |
|
All related tests passed in their separate runs. |
Venefilyn
added
the
skip/changelog
On CentOS and Oracle Linux 7 the test was failing because we were renaming the vmlinuz and initramfs files in order to back them up, but we left them in the /boot/ folder. That caused the grub2-mkconfig to pick them up and generated a new grub configuration using these renamed boot files. This change does not back up the boot files but instead simply removes them, simulating better the core test scenario of this integration test which is the kernel rpm scriptlet failure to copy/generate these boot files. After verifying that convert2rhel detected this situation of missing boot files correctly, the test goes on to do what the user instructed to do in such a case - that is reinstalling the kernel and re-runing grub2-mkconfig. Fixes #721.
On CentOS and Oracle Linux 7 the test was failing because we were renaming the vmlinuz, thinking that it's enough to simulate that they are not present. But leaving them renamed in the /boot/ folder caused that the grub2-mkconfig picked them up and generated a new grub configuration using these renamed boot files:
Full test failure log: http://artifacts.osci.redhat.com/testing-farm/686cea0f-2101-49a5-9a57-0424d12e2d53/work-kernel_boot_files_missing_initramfs_and_vmlinuzqarmzy43/log.txt.
This test fix stops renaming the boot files and instead it simply removes them, simulating better the core test scenario of this integration test (the kernel rpm scriptlet failure to copy/generate the boot files). After verifying that convert2rhel detected this situation of missing boot files correctly, the test goes on to do what the user is instructed to do in such a case - that is reinstalling the kernel and re-runing grub2-mkconfig.
Fixes #721.
Jira Issue: RHELC-752
Checklist
[RHELC-]is part of the PR titleRelease Pending