tests/hotfix/Remove parsing .env in conftest #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]>
bocekm
approved these changes
May 22, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
=======================================
Coverage 94.05% 94.05%
=======================================
Files 40 40
Lines 3837 3837
Branches 679 679
=======================================
Hits 3609 3609
Misses 163 163
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
r0x0d
added
the
skip/changelog
Venefilyn
pushed a commit
that referenced
this pull request
Jun 19, 2023
* we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]>
Andrew-ang9
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Aug 16, 2023
* we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]> Modify tests * use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Revised checks.py and checks_test.py * After Rebasing some of the code changed, and added in code not from this PR. * In checks.py the log message was edited and the rest of the code. * In checks_test.py edited is_loaded_kernel_latet_unsupported_skip, and added is_loaded_kernel_latet_unsupported_skip_env_var * Use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Use the deprecated envar in latest_kernel_check_skip Signed-off-by: Daniel Diblik <[email protected]>
Andrew-ang9
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Aug 16, 2023
* we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]> Modify tests * use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Revised checks.py and checks_test.py * After Rebasing some of the code changed, and added in code not from this PR. * In checks.py the log message was edited and the rest of the code. * In checks_test.py edited is_loaded_kernel_latet_unsupported_skip, and added is_loaded_kernel_latet_unsupported_skip_env_var * Use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Use the deprecated envar in latest_kernel_check_skip Signed-off-by: Daniel Diblik <[email protected]>
Andrew-ang9
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Sep 26, 2023
* we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]> Modify tests * use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Revised checks.py and checks_test.py * After Rebasing some of the code changed, and added in code not from this PR. * In checks.py the log message was edited and the rest of the code. * In checks_test.py edited is_loaded_kernel_latet_unsupported_skip, and added is_loaded_kernel_latet_unsupported_skip_env_var * Use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Use the deprecated envar in latest_kernel_check_skip Signed-off-by: Daniel Diblik <[email protected]>
Andrew-ang9
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Nov 1, 2023
tests/hotfix/Remove parsing .env in conftest (oamg#838) * we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]> Modify tests * use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Revised checks.py and checks_test.py * After Rebasing some of the code changed, and added in code not from this PR. * In checks.py the log message was edited and the rest of the code. * In checks_test.py edited is_loaded_kernel_latet_unsupported_skip, and added is_loaded_kernel_latet_unsupported_skip_env_var * Use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Use the deprecated envar in latest_kernel_check_skip Signed-off-by: Daniel Diblik <[email protected]> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci fixed the log message * I belive that there is still an issue with the log message as I think the assert for the action is fails because of that, I am currently lookign into that though Changed the action level description message refactored the if statment * this if statment now takes in account what envar is being used and will display the correct message acordingly reverted the if statment back to the correct format fix for the unit tests * This is a temporary fix for the uint test I had to seperate one tests from the is_loaded_kernel_latest_skip_warnings as it wasn't passing with the log message test. For some unknown reason the envar is only set in all of the tests.
Andrew-ang9
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Dec 12, 2023
tests/hotfix/Remove parsing .env in conftest (oamg#838) * we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]> Modify tests * use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Revised checks.py and checks_test.py * After Rebasing some of the code changed, and added in code not from this PR. * In checks.py the log message was edited and the rest of the code. * In checks_test.py edited is_loaded_kernel_latet_unsupported_skip, and added is_loaded_kernel_latet_unsupported_skip_env_var * Use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Use the deprecated envar in latest_kernel_check_skip Signed-off-by: Daniel Diblik <[email protected]> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci fixed the log message * I belive that there is still an issue with the log message as I think the assert for the action is fails because of that, I am currently lookign into that though Changed the action level description message refactored the if statment * this if statment now takes in account what envar is being used and will display the correct message acordingly reverted the if statment back to the correct format fix for the unit tests * This is a temporary fix for the uint test I had to seperate one tests from the is_loaded_kernel_latest_skip_warnings as it wasn't passing with the log message test. For some unknown reason the envar is only set in all of the tests.
Andrew-ang9
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Jan 2, 2024
tests/hotfix/Remove parsing .env in conftest (oamg#838) * we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]> Modify tests * use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Revised checks.py and checks_test.py * After Rebasing some of the code changed, and added in code not from this PR. * In checks.py the log message was edited and the rest of the code. * In checks_test.py edited is_loaded_kernel_latet_unsupported_skip, and added is_loaded_kernel_latet_unsupported_skip_env_var * Use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Use the deprecated envar in latest_kernel_check_skip Signed-off-by: Daniel Diblik <[email protected]> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci fixed the log message * I belive that there is still an issue with the log message as I think the assert for the action is fails because of that, I am currently lookign into that though Changed the action level description message refactored the if statment * this if statment now takes in account what envar is being used and will display the correct message acordingly reverted the if statment back to the correct format fix for the unit tests * This is a temporary fix for the uint test I had to seperate one tests from the is_loaded_kernel_latest_skip_warnings as it wasn't passing with the log message test. For some unknown reason the envar is only set in all of the tests.
Andrew-ang9
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Jan 15, 2024
tests/hotfix/Remove parsing .env in conftest (oamg#838) * we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]> Modify tests * use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Revised checks.py and checks_test.py * After Rebasing some of the code changed, and added in code not from this PR. * In checks.py the log message was edited and the rest of the code. * In checks_test.py edited is_loaded_kernel_latet_unsupported_skip, and added is_loaded_kernel_latet_unsupported_skip_env_var * Use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Use the deprecated envar in latest_kernel_check_skip Signed-off-by: Daniel Diblik <[email protected]> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci fixed the log message * I belive that there is still an issue with the log message as I think the assert for the action is fails because of that, I am currently lookign into that though Changed the action level description message refactored the if statment * this if statment now takes in account what envar is being used and will display the correct message acordingly reverted the if statment back to the correct format fix for the unit tests * This is a temporary fix for the uint test I had to seperate one tests from the is_loaded_kernel_latest_skip_warnings as it wasn't passing with the log message test. For some unknown reason the envar is only set in all of the tests.
Venefilyn
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Rewrite is_loaded_kernel_latest() log messages tests/hotfix/Remove parsing .env in conftest (#838) * we do not have any .env file in the repository, the line is redundant Signed-off-by: Daniel Diblik <[email protected]> Modify tests * use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Revised checks.py and checks_test.py * After Rebasing some of the code changed, and added in code not from this PR. * In checks.py the log message was edited and the rest of the code. * In checks_test.py edited is_loaded_kernel_latet_unsupported_skip, and added is_loaded_kernel_latet_unsupported_skip_env_var * Use `CONVERT2RHEL_SKIP_KERNEL_CURRENCY_CHECK` instead of deprecated `CONVERT2RHEL_UNSUPPORTED_SKIP_KERNEL_CURRENCY_CHECK` Signed-off-by: Daniel Diblik <[email protected]> Use the deprecated envar in latest_kernel_check_skip Signed-off-by: Daniel Diblik <[email protected]> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci fixed the log message * I belive that there is still an issue with the log message as I think the assert for the action is fails because of that, I am currently lookign into that though Changed the action level description message refactored the if statment * this if statment now takes in account what envar is being used and will display the correct message acordingly reverted the if statment back to the correct format fix for the unit tests * This is a temporary fix for the uint test I had to seperate one tests from the is_loaded_kernel_latest_skip_warnings as it wasn't passing with the log message test. For some unknown reason the envar is only set in all of the tests. * Removed duplicate code * Wip needs one more test to pass unit testing * Changed the id and what log for the unit test --------- Co-authored-by: Daniel Diblik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on CentOS-8.4 with tier0 set:
http://artifacts.osci.redhat.com/testing-farm/8a854bf5-2487-494b-9dfd-0cfe2c53a8a0/