[RHELC-1070] Duplicate package check for preconversion analysis #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-watson
added
kind/feature
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
==========================================
- Coverage 94.34% 94.34% -0.01%
==========================================
Files 47 48 +1
Lines 4580 4595 +15
Branches 818 821 +3
==========================================
+ Hits 4321 4335 +14
Misses 182 182
- Partials 77 78 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
convert2rhel/unit_tests/actions/system_checks/duplicate_packages_test.py
Fixed
Show fixed
Hide fixed
r0x0d
reviewed
Nov 21, 2023
r0x0d
reviewed
Nov 21, 2023
pr-watson
force-pushed
the
duplicate-packages
branch
from
e2aab94 to
1f6480d
Compare
|
/packit test |
|
/packit build |
|
/packit test |
1 similar comment
|
/packit test |
r0x0d
reviewed
Dec 13, 2023
pr-watson
force-pushed
the
duplicate-packages
branch
from
1f6480d to
9589867
Compare
Venefilyn
requested changes
Jan 4, 2024
Venefilyn
reviewed
Jan 4, 2024
convert2rhel/unit_tests/actions/system_checks/duplicate_packages_test.py
Show resolved
Hide resolved
pr-watson
force-pushed
the
duplicate-packages
branch
from
9589867 to
0b1406a
Compare
r0x0d
reviewed
Jan 22, 2024
r0x0d
reviewed
Jan 22, 2024
r0x0d
reviewed
Jan 22, 2024
r0x0d
reviewed
Jan 22, 2024
convert2rhel/unit_tests/actions/system_checks/duplicate_packages_test.py
Fixed
Show fixed
Hide fixed
pr-watson
force-pushed
the
duplicate-packages
branch
2 times, most recently
from
c35b1e7 to
a0de28c
Compare
|
/packit test |
pr-watson
force-pushed
the
duplicate-packages
branch
from
a0de28c to
a02d991
Compare
Venefilyn
approved these changes
Feb 14, 2024
|
/packit test |
|
With the Ethel Stage refresh going on today all tests here will be failing |
|
/packit build |
Co-authored-by: Rodolfo Olivieri <[email protected]>
|
/packit test |
4 similar comments
|
/packit test |
|
/packit test |
|
/packit test |
|
/packit test |
|
/packit retest-failed |
|
Once #1095 is merged the integration test failures related to the redhatrelease file backup should be fixed |
Merged
jochapma
pushed a commit
to jochapma/convert2rhel
that referenced
this pull request
Mar 11, 2024
…#987) * [RHELC-1070] Duplicate package check for preconversion analysis * Update convert2rhel/actions/system_checks/duplicate_packages.py Co-authored-by: Rodolfo Olivieri <[email protected]> --------- Co-authored-by: Freya Gustavsson <[email protected]> Co-authored-by: Rodolfo Olivieri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to preconversion analysis to run "package-cleanup --dupes" to see if the users system contains multiple versions of the same package. If multiple versions of the same package are detected then an error is raised and the user is instructed to remove the duplicate packages with the help of the package-cleanup command.
Jira Issues: RHELC-1070
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant