Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR bot welcome msg #1220

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented May 4, 2024

I found useful to be able to run just failed tests (when they crashed due to infrastructure issues). Updating the welcome msg to provide this info and little bit restructured original statement, to make it more friendly for reading. I've updated the bot msg below manually to show the expected content.

Copy link

github-actions bot commented May 4, 2024

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - master - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89 pirat89 changed the title github actions: Update to Node20 (checkout v4) GH actions: Update to Node20 (checkout v4) + msg update May 6, 2024
@pirat89 pirat89 force-pushed the update-checkout-workflow branch from 1a50ac7 to 46820a0 Compare May 6, 2024 07:42
@pirat89
Copy link
Member Author

pirat89 commented May 6, 2024

@oamg/developers note that /packit retest-failed command is not buggy: packit/packit-service#1886 - so I can think about dropping it for now from the msg. but it's possibly it will be fixed during next month. wdyt? keep it or drop it and put it back once it's fixed?

@r0x0d
Copy link
Member

r0x0d commented May 6, 2024

@pirat89, why not using dependabot or renovate to keep the dependencies up-to-date? With renovate, you can have more configurable settings for how many PRs it will open in a give period, I believe.

@pirat89
Copy link
Member Author

pirat89 commented May 6, 2024

@r0x0d well, we can take a look. I am not so familiar with it, but original approach to use dependabot in the project was to automatically inform about newer python packages available (when installing by pip to run unit-tests) and basically we didn't want any info about newer python apps available. if we can use it to track just particular deps, I think it could be potentially useful in future.

@r0x0d
Copy link
Member

r0x0d commented May 6, 2024

@r0x0d well, we can take a look. I am not so familiar with it, but original approach to use dependabot in the project was to automatically inform about newer python packages available (when installing by pip to run unit-tests) and basically we didn't want any info about newer python apps available. if we can use it to track just particular deps, I think it could be potentially useful in future.

I will look into setting up renovate for leapp-repository. I will message you in slack to check which type of deps you want to get info.

@evgeni
Copy link
Member

evgeni commented May 6, 2024

@r0x0d well, we can take a look. I am not so familiar with it, but original approach to use dependabot in the project was to automatically inform about newer python packages available (when installing by pip to run unit-tests) and basically we didn't want any info about newer python apps available. if we can use it to track just particular deps, I think it could be potentially useful in future.

dependabot can be configured to look at certain "ecosystems"/"package managers" only, so bump actions but not python, etc.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#example-of-a-basic-setup-for-three-package-managers

@r0x0d
Copy link
Member

r0x0d commented May 7, 2024

Created #1221

@pirat89 pirat89 force-pushed the update-checkout-workflow branch from 46820a0 to f4ab033 Compare May 14, 2024 12:38
@pirat89 pirat89 changed the title GH actions: Update to Node20 (checkout v4) + msg update Update PR bot welcome msg May 14, 2024
@pirat89 pirat89 requested a review from a team May 14, 2024 12:38
I found useful to be able to run just failed tests (when they crashed
due to infrastructure issues). Updating the welcome msg to provide
this info and little bit restructured original statement, to make
it more friendly for reading.
@pirat89 pirat89 force-pushed the update-checkout-workflow branch from f4ab033 to c4f7b0c Compare May 14, 2024 15:50
@matejmatuska
Copy link
Member

@pirat89 I know #1221 is already merged, just one thing to keep in mind is that when a GH Action is updated, we have to change the allowed version in repository setting too. That's what broke the pr-welcome-message-bot and shellcheck.

@pirat89 pirat89 merged commit f3913f7 into oamg:master Jun 19, 2024
13 checks passed
@pirat89 pirat89 deleted the update-checkout-workflow branch June 19, 2024 10:08
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants