This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-429] TPC-DS Q14a/b get slowed down within setting spark.oap.sql.columnar.sortmergejoin.lazyread=true #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhztheplayer
changed the title
|
Ready to merge once CI check passed |
zhouyuan
reviewed
Aug 4, 2021
| @@ -317,19 +288,23 @@ class TypedLazyLoadRelationColumn<DataType, enable_if_string_like<DataType>> | |||
| return arrow::Status::OK(); | |||
There was a problem hiding this comment.
Should be able to apply below patch to optimize the null check
diff --git a/native-sql-engine/cpp/src/codegen/common/relation_column.h b/native-sql-engine/cpp/src/codegen/common/relation_column.h
index 33bf151d..66e78601 100644
--- a/native-sql-engine/cpp/src/codegen/common/relation_column.h
+++ b/native-sql-engine/cpp/src/codegen/common/relation_column.h
@@ -216,6 +216,8 @@ class TypedLazyLoadRelationColumn<DataType, enable_if_number_or_decimal<DataType
in_ = in;
field_id_ = field_id;
return arrow::Status::OK();
+ AdvanceTo(0);
+ has_null_ = TypedRelationColumn<DataType>::HasNull();
};
void AdvanceTo(int array_id) override {
zhouyuan
added a commit
that referenced
this pull request
Aug 5, 2021
* Minor: Remove debug code for PR#387 (#431) * [NSE-436] Fix for Arrow Data Source test suite (#437) Closes #436 * [NSE-254]Solve the redundant arrow library issue (#440) * [NSE-254]Issue0410 jar size (#441) * [NSE-254]Solve the redundant arrow library issue * Remove mvn jar plugin 3.2.0 * fix packaging (#442) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Yuan Zhou <[email protected]> * [NSE-207] Fix aggregate and refresh UT test script (#426) * fix expr id difference in Partial Aggregate * add fallback to window * refresh ut * use stol instead of stoi * enable ut full test * [NSE-429] TPC-DS Q14a/b get slowed down within setting spark.oap.sql.columnar.sortmergejoin.lazyread=true (#432) * wip * debug commit * wip * discard proxy pattern * fix * fix * fix * fix unexpected O(n^2) time * fix1 * fix2 * Add a bunch of caches; Adjust prefetch batch length to 16 * format * fix * disable spark.oap.sql.columnar.sortmergejoin.lazyread by default * fix Co-authored-by: Hongze Zhang <[email protected]> Co-authored-by: Wei-Ting Chen <[email protected]> Co-authored-by: Rui Mo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.