[ML-284][LinearRegression][Follow-up] Add Linear Regression unit test for GPU and fix fitIntercept #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwu99
requested changes
May 26, 2023
mllib-dal/src/main/scala/com/intel/oap/mllib/regression/LinearRegressionDALImpl.scala
Outdated
Show resolved
Hide resolved
mllib-dal/src/main/scala/com/intel/oap/mllib/regression/LinearRegressionDALImpl.scala
Outdated
Show resolved
Hide resolved
mllib-dal/src/main/scala/com/intel/oap/mllib/regression/LinearRegressionDALImpl.scala
Show resolved
Hide resolved
mllib-dal/src/main/scala/org/apache/spark/ml/regression/spark313/LinearRegression.scala
Outdated
Show resolved
Hide resolved
mllib-dal/src/main/scala/org/apache/spark/ml/regression/spark313/LinearRegression.scala
Outdated
Show resolved
Hide resolved
mllib-dal/src/main/scala/org/apache/spark/ml/regression/spark321/LinearRegression.scala
Outdated
Show resolved
Hide resolved
mllib-dal/src/main/scala/org/apache/spark/ml/regression/spark321/LinearRegression.scala
Outdated
Show resolved
Hide resolved
mllib-dal/src/main/scala/org/apache/spark/ml/regression/spark321/LinearRegression.scala
Outdated
Show resolved
Hide resolved
CPU and GPU unit test are separated
xwu99
changed the title
xwu99
changed the title
xwu99
changed the title
|
Merged. thanks for your hard work! |
minmingzhu
pushed a commit
to minmingzhu/oap-mllib
that referenced
this pull request
Jun 1, 2023
… for GPU and fix fitIntercept (oap-project#287) * Add gpu unit test work around * LR unit test repair CPU and GPU unit test are separated * Seperate test.sh add new test for LR * Tmp stage * FULL test to check up * UT need to be cleaned up * Singular matrix is not supported * CPU ridge regression got the wrong ans * CPU is fixed * Device select * Comment singular * Recover files * Fix raw test * Fix code style * Fix format * Update test.sh * Fix comments format * Format of test.sh * Fix space format * Fix comment * Fix cpp log * Fix cpp format * Update MLlibLinearRegressionSuite.scala --------- Co-authored-by: Xiaochang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #284)