Add flag for sort in window (#321)

* add flag for sort in window op * minor change
oap-project · Jun 20, 2023 · 8358991 · 8358991
1 parent 1711354
commit 8358991
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/velox/exec/Window.cpp b/velox/exec/Window.cpp
@@ -17,6 +17,8 @@
 #include "velox/exec/OperatorUtils.h"
 #include "velox/exec/Task.h"
 
+DEFINE_bool(SkipRowSortInWindowOp, false, "Skip row sort");
+
 namespace facebook::velox::exec {
 
 namespace {
@@ -277,13 +279,14 @@ void Window::sortPartitions() {
   sortedRows_.resize(numRows_);
   RowContainerIterator iter;
   data_->listRows(&iter, numRows_, sortedRows_.data());
-
-  std::sort(
-      sortedRows_.begin(),
-      sortedRows_.end(),
-      [this](const char* leftRow, const char* rightRow) {
-        return compareRowsWithKeys(leftRow, rightRow, allKeyInfo_);
-      });
+  if (!FLAGS_SkipRowSortInWindowOp) {
+    std::sort(
+        sortedRows_.begin(),
+        sortedRows_.end(),
+        [this](const char* leftRow, const char* rightRow) {
+          return compareRowsWithKeys(leftRow, rightRow, allKeyInfo_);
+        });
+  }
 
   computePartitionStartRows();