forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-1712] Create folder if not exits on HDFS write #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
reviewed
May 23, 2023
// Check whether the parentDir exist, create it if not exist. | ||
if (hdfsExists(hdfsClient_, parentDir.c_str()) == -1) { | ||
hdfsCreateDirectory(hdfsClient_, parentDir.c_str()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this work for "/example.parquet" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This ut can test this case.
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 3, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 4, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 11, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 17, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.