Fix semantic issues in cast function #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 26, 2023
|
@zhejiangxiaomai This PR will cause DateTimeFunctionsTest.dateFunctionVarchar and DateTimeFunctionsTest.timeZoneHour failed in main_rebase_526. We should not catch exceptions in the public methods of Presto and Spark. Presto defaults to ANSI mode and needs to throw exceptions. |
Regarding semantic issues for common functions, we have a discussion in velox upstream: facebookincubator#4876. |
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: Allow decimal in casting string to int oap-project#215 Add mapping from named_struct to row_constructor oap-project#214 Fix semantic issues in cast function oap-project#280
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: Allow decimal in casting string to int oap-project#215 Add mapping from named_struct to row_constructor oap-project#214 Fix semantic issues in cast function oap-project#280
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 25, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 25, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 26, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 27, 2023
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 3, 2023
relative pr: Allow decimal in casting string to int oap-project#215 Add mapping from named_struct to row_constructor oap-project#214 Fix semantic issues in cast function oap-project#280
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Allow decimal in casting string to int oap-project#215 Add mapping from named_struct to row_constructor oap-project#214 Fix semantic issues in cast function oap-project#280
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 11, 2023
relative pr: Allow decimal in casting string to int oap-project#215 Add mapping from named_struct to row_constructor oap-project#214 Fix semantic issues in cast function oap-project#280
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: Allow decimal in casting string to int oap-project#215 Add mapping from named_struct to row_constructor oap-project#214 Fix semantic issues in cast function oap-project#280
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: Allow decimal in casting string to int oap-project#215 Add mapping from named_struct to row_constructor oap-project#214 Fix semantic issues in cast function oap-project#280
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Allow decimal in casting string to int oap-project#215 Add mapping from named_struct to row_constructor oap-project#214 Fix semantic issues in cast function oap-project#280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR directly changes the code for cast function. In the future, we plan to separate the impl. for common function to respectively adapt to spark/presto semantic.