[GLUTEN-2038][VL][FOLLOWUP] Fix and add test #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @JkSelf @zhejiangxiaomai thank you |
Merged
|
After this pr passed, I can make a new pr to fix format check. |
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
…void memory copy with string type (oap-project#335)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why
E2EFilterTest .metadataFilterfailed is that, it tests the filter pushdown using row group metadata but after #326 it only has one row group. This prs change the max rows in one row group to 10 which is aligned with the test batch size, so that each batch can produce a row group.Besides, this pr adds a new test to check we can combine small batches into a big row group.