Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bin function support #349

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Add bin function support #349

merged 1 commit into from
Jul 5, 2023

Conversation

Yohahaha
Copy link

@Yohahaha Yohahaha commented Jul 4, 2023 •
edited
Loading

@zhejiangxiaomai zhejiangxiaomai merged commit 386f25e into oap-project:main Jul 5, 2023
@Yohahaha Yohahaha deleted the bin_func branch July 5, 2023 03:40
@rui-mo
Copy link
Collaborator

rui-mo commented Jul 5, 2023

Hi @Yohahaha, bin is not an aggregation function, so there's no need to add it to the white list, am I right?

@Yohahaha
Copy link
Author

Yohahaha commented Jul 5, 2023

Hi @Yohahaha, bin is not an aggregation function, so there's no need to add it to the white list, am I right?

Yes, you're right... thanks!

@Yohahaha Yohahaha mentioned this pull request Jul 5, 2023
Merged
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jul 11, 2023
@Yohahaha @zhejiangxiaomai
add bin support (oap-project#349)
619340a
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jul 12, 2023
@Yohahaha @zhejiangxiaomai
add bin support (oap-project#349)
13b77db
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jul 12, 2023
@Yohahaha @zhejiangxiaomai
add bin support (oap-project#349)
1b6c8da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yohahaha @rui-mo @zhejiangxiaomai