Fix incorrect result in lazy vector #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
changed the title
rui-mo
added a commit
that referenced
this pull request
Aug 12, 2022
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Aug 18, 2022
zhejiangxiaomai
pushed a commit
that referenced
this pull request
Aug 24, 2022
zhejiangxiaomai
pushed a commit
that referenced
this pull request
Sep 1, 2022
xieqi
pushed a commit
to Intel-bigdata/velox
that referenced
this pull request
Sep 16, 2022
…ap-project#37) * init commit of function registry * code refactor * code structure re-org * partial implementation for function lookup and function collector * complete the function signature lookup development * parse substrait extension yaml files as SubstraitExtension * parse substrait unknown type * parse substrait unknown type * parse substrait unknown type * add if/switch test case * revert change for FilterProjectTest.cpp * revert CMakeLists.txt * typo * code refactor for function lookup * remove virtual * move defintion of SubstraitFunction outside of SubstraitExtension.h * revert typeUtils * add comments * code style tidy * optimize code structure of SubstraitType.h * add test case for type lookup * code style fix * consolidate code of function variant decode & code refactor * revert change of CMakeLists.txt * use VELOX_NYI to throw exception instead of using std runtime directly * revert CMakeLists.txt * use VELOX_NYI to throw exception instead of using std runtime directly * add lookup scalar function and aggregate function by provided reference and extension * support lookup function with signature and function mappings * revert format change for CMakeLists.txt * revert format change for CMakeLists.txt * rollback change of velox/CMakeLists.txt * comments provided for SubstraitFunctionMappings.h use ASSERT_EQ instead of ASSERT_TRUE for value comparasion * some code style fix and class renaming * provide the default implementation for SubstraitFunctionMappings.h * code refactor to make code more clean * support signature with difference wildcard type * support wildcard function variant with different types
ZJie1
pushed a commit
to Intel-bigdata/velox
that referenced
this pull request
Oct 20, 2022
…ap-project#37) * init commit of function registry * code refactor * code structure re-org * partial implementation for function lookup and function collector * complete the function signature lookup development * parse substrait extension yaml files as SubstraitExtension * parse substrait unknown type * parse substrait unknown type * parse substrait unknown type * add if/switch test case * revert change for FilterProjectTest.cpp * revert CMakeLists.txt * typo * code refactor for function lookup * remove virtual * move defintion of SubstraitFunction outside of SubstraitExtension.h * revert typeUtils * add comments * code style tidy * optimize code structure of SubstraitType.h * add test case for type lookup * code style fix * consolidate code of function variant decode & code refactor * revert change of CMakeLists.txt * use VELOX_NYI to throw exception instead of using std runtime directly * revert CMakeLists.txt * use VELOX_NYI to throw exception instead of using std runtime directly * add lookup scalar function and aggregate function by provided reference and extension * support lookup function with signature and function mappings * revert format change for CMakeLists.txt * revert format change for CMakeLists.txt * rollback change of velox/CMakeLists.txt * comments provided for SubstraitFunctionMappings.h use ASSERT_EQ instead of ASSERT_TRUE for value comparasion * some code style fix and class renaming * provide the default implementation for SubstraitFunctionMappings.h * code refactor to make code more clean * support signature with difference wildcard type * support wildcard function variant with different types
ZJie1
pushed a commit
to Intel-bigdata/velox
that referenced
this pull request
Dec 14, 2022
…ap-project#37) * init commit of function registry * code refactor * code structure re-org * partial implementation for function lookup and function collector * complete the function signature lookup development * parse substrait extension yaml files as SubstraitExtension * parse substrait unknown type * parse substrait unknown type * parse substrait unknown type * add if/switch test case * revert change for FilterProjectTest.cpp * revert CMakeLists.txt * typo * code refactor for function lookup * remove virtual * move defintion of SubstraitFunction outside of SubstraitExtension.h * revert typeUtils * add comments * code style tidy * optimize code structure of SubstraitType.h * add test case for type lookup * code style fix * consolidate code of function variant decode & code refactor * revert change of CMakeLists.txt * use VELOX_NYI to throw exception instead of using std runtime directly * revert CMakeLists.txt * use VELOX_NYI to throw exception instead of using std runtime directly * add lookup scalar function and aggregate function by provided reference and extension * support lookup function with signature and function mappings * revert format change for CMakeLists.txt * revert format change for CMakeLists.txt * rollback change of velox/CMakeLists.txt * comments provided for SubstraitFunctionMappings.h use ASSERT_EQ instead of ASSERT_TRUE for value comparasion * some code style fix and class renaming * provide the default implementation for SubstraitFunctionMappings.h * code refactor to make code more clean * support signature with difference wildcard type * support wildcard function variant with different types
ZJie1
added a commit
to Intel-bigdata/velox
that referenced
this pull request
Feb 7, 2023
…ter velox update (hard code now) (oap-project#40) [POAE7-1598] [Velox2Substrait] function convertor using yaml format (oap-project#37) * init commit of function registry * code refactor * code structure re-org * partial implementation for function lookup and function collector * complete the function signature lookup development * parse substrait extension yaml files as SubstraitExtension * parse substrait unknown type * parse substrait unknown type * parse substrait unknown type * add if/switch test case * revert change for FilterProjectTest.cpp * revert CMakeLists.txt * typo * code refactor for function lookup * remove virtual * move defintion of SubstraitFunction outside of SubstraitExtension.h * revert typeUtils * add comments * code style tidy * optimize code structure of SubstraitType.h * add test case for type lookup * code style fix * consolidate code of function variant decode & code refactor * revert change of CMakeLists.txt * use VELOX_NYI to throw exception instead of using std runtime directly * revert CMakeLists.txt * use VELOX_NYI to throw exception instead of using std runtime directly * add lookup scalar function and aggregate function by provided reference and extension * support lookup function with signature and function mappings * revert format change for CMakeLists.txt * revert format change for CMakeLists.txt * rollback change of velox/CMakeLists.txt * comments provided for SubstraitFunctionMappings.h use ASSERT_EQ instead of ASSERT_TRUE for value comparasion * some code style fix and class renaming * provide the default implementation for SubstraitFunctionMappings.h * code refactor to make code more clean * support signature with difference wildcard type * support wildcard function variant with different types
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
* change CMakeLists to align with the upgraded substrait * parsing update * refine proto compiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picked the change of PR#2089 from upstream Velox to oap Velox. Should be removed after rebase.