Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register merge extract companion agg functions without suffix #468

Closed
wants to merge 3 commits into from

Conversation

zhztheplayer
Copy link
Collaborator

Required by apache/incubator-gluten#4130, reverts #465 and #453

@zhztheplayer zhztheplayer marked this pull request as ready for review January 3, 2024 06:23
@zhztheplayer zhztheplayer force-pushed the wip-fix-agg branch 2 times, most recently from f45ecc1 to 0ed098c Compare January 3, 2024 07:05
@zhztheplayer zhztheplayer changed the base branch from update to 2024_01_03 January 4, 2024 08:16
@zhztheplayer zhztheplayer changed the base branch from 2024_01_03 to 2024_01_04 January 4, 2024 08:17
@zhztheplayer zhztheplayer changed the base branch from 2024_01_04 to update January 4, 2024 13:52
@zhztheplayer zhztheplayer force-pushed the wip-fix-agg branch 2 times, most recently from 0092f72 to 1690b42 Compare January 5, 2024 06:59
@zhztheplayer zhztheplayer changed the base branch from update to 2024_01_05 January 5, 2024 07:44
@rui-mo
Copy link
Collaborator

rui-mo commented Jan 5, 2024

Could you resolve the format issue? Thanks.

@zhztheplayer zhztheplayer force-pushed the wip-fix-agg branch 2 times, most recently from 85ff19d to e414f59 Compare January 5, 2024 08:51
@zhztheplayer zhztheplayer marked this pull request as draft January 5, 2024 08:52
@zhztheplayer
Copy link
Collaborator Author

Could you resolve the format issue? Thanks.

velox/type/DecimalUtil.h:181:35: error: code should be clang-formatted [-Wclang-format-violations]
            DecimalUtil::toString(inputValue, DECIMAL(fromPrecision, fromScale)),

I think this one is from previous commit. Let's fix it during next rebase. cc @marin-ma

@marin-ma
Copy link
Collaborator

marin-ma commented Jan 5, 2024

Could you resolve the format issue? Thanks.

velox/type/DecimalUtil.h:181:35: error: code should be clang-formatted [-Wclang-format-violations]
            DecimalUtil::toString(inputValue, DECIMAL(fromPrecision, fromScale)),

I think this one is from previous commit. Let's fix it during next rebase. cc @marin-ma

Thanks. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants