Nanos in timestamp INT96 can be negative #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
reviewed
Mar 26, 2024
velox/type/Timestamp.h
Outdated
| @@ -101,7 +101,7 @@ struct Timestamp { | |||
|
|
|||
| constexpr Timestamp() : seconds_(0), nanos_(0) {} | |||
|
|
|||
| Timestamp(int64_t seconds, uint64_t nanos) | |||
| Timestamp(int64_t seconds, int64_t nanos) | |||
| : seconds_(seconds), nanos_(nanos) { | |||
There was a problem hiding this comment.
nanos_ is still uint64_t, do we need to change it?
|
Included this change in facebookincubator#4680, and we could remove this commit from this repo after repicking facebookincubator#4680. cc: @marin-ma |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the time point represented by the timestamp is before 1970, the nanos in the INT96 representation of the timestamp may be negative.