Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove velox prefix in proto files #6

Merged
merged 1 commit into from
May 6, 2022
Merged

Remove velox prefix in proto files #6

merged 1 commit into from
May 6, 2022

Conversation

rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented May 6, 2022

To satisfy the needs of Meta's internal tests, the Substrait proto files were added with some Velox prefixes, which would cause compilation failure on other test environments. This PR removed them.

@rui-mo rui-mo merged commit 4601419 into oap-project:main May 6, 2022
zhejiangxiaomai pushed a commit that referenced this pull request Jun 9, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
f1a384c
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Jun 13, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
3157616
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Jun 16, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
44056e9
zhejiangxiaomai pushed a commit that referenced this pull request Jun 21, 2022
@rui-mo
Remove Velox prefixes in Substrait proto files (#6)
3db6d76
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Jun 29, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
d4fbe7a
zhejiangxiaomai pushed a commit that referenced this pull request Jul 12, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
3654af9
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Jul 26, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
bc0902e
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Aug 9, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
0608ecd
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Aug 17, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
573fc7e
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Aug 18, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
f34d592
YantingTao1315 referenced this pull request in Intel-bigdata/velox Aug 19, 2022
@mbasmanova @facebook-github-bot
Identify common sub-expressions in printExprWithStats (facebookincuba…
a34d9a0 
…tor#1500)

Summary:
Enhance printExprWithStats to identify common-sub expressions.

For example, `c0 + c1` is a common sub-expression in
`"(c0 + c1) % 5", " (c0 + c1) % 3"` expression set. It is evaluated only once and
there is a single Expr object that represents it. That object appears in the
expression tree twice. printExprWithStats does not show the runtime stats for
second instance of that expression and instead annotates it with `[CSE https://github.com/facebookincubator/velox/issues/2]`,
where CSE stands for common sub-expression and 2 refers to the first instance
of the expression.

```
mod [cpu time: 50.49us, rows: 1024] -> BIGINT [#1]
   cast(plus as BIGINT) [cpu time: 68.15us, rows: 1024] -> BIGINT [#2]
      plus [cpu time: 51.84us, rows: 1024] -> INTEGER [#3]
         c0 [cpu time: 0ns, rows: 0] -> INTEGER [#4]
         c1 [cpu time: 0ns, rows: 0] -> INTEGER [#5]
   5:BIGINT [cpu time: 0ns, rows: 0] -> BIGINT [#6]

mod [cpu time: 49.29us, rows: 1024] -> BIGINT [#7]
   cast((plus(c0, c1)) as BIGINT) -> BIGINT [CSE #2]
   3:BIGINT [cpu time: 0ns, rows: 0] -> BIGINT [#8]
```

Pull Request resolved: facebookincubator#1500

Reviewed By: Yuhta

Differential Revision: D35994836

Pulled By: mbasmanova

fbshipit-source-id: 6bacbbe61b68dad97ce2fd5f99610c4ad55897be
zhejiangxiaomai pushed a commit that referenced this pull request Aug 24, 2022
@rui-mo
Remove Velox prefixes in Substrait proto files (#6)
195ab0b
zhejiangxiaomai pushed a commit that referenced this pull request Sep 1, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
5f47eea
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Sep 16, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
ee2e524
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Sep 22, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
6443bc7
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Oct 20, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
694912d
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Oct 20, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
ba79df4
zhejiangxiaomai pushed a commit that referenced this pull request Nov 7, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
1938b38
zhejiangxiaomai pushed a commit that referenced this pull request Nov 8, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
425b9a8
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Nov 18, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
c371905
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Dec 12, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
15147d7
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Dec 13, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
c7f0891
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Dec 14, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
916ef6c
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Dec 14, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
6b4ad53
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Dec 15, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
0424089
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Dec 15, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
d3deefa
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Dec 21, 2022
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
5b905b5
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Jan 3, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
bdcaa8d
zhejiangxiaomai pushed a commit that referenced this pull request Jan 11, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
126e00d
zhejiangxiaomai pushed a commit that referenced this pull request Jan 11, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
4fa0183
zhejiangxiaomai pushed a commit that referenced this pull request Jan 31, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
b3cf4ce
zhejiangxiaomai pushed a commit that referenced this pull request Feb 22, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
ec57288
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Feb 27, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
647ba57
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Mar 6, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
0f5f2e0
jinchengchenghh pushed a commit to jinchengchenghh/velox that referenced this pull request Mar 15, 2023
@liujiayi771 @JkSelf
add decimal avg prefix (oap-project#6)
5c6aa89
jinchengchenghh pushed a commit to jinchengchenghh/velox that referenced this pull request Mar 20, 2023
@liujiayi771 @JkSelf
add decimal avg prefix (oap-project#6)
dc7df75
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Mar 27, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
0679e47
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Mar 29, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
6e2d041
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Mar 29, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
b76d933
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Apr 14, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
8edf3c3
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Apr 17, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
51fcb8b
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Apr 19, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
7fd763b
zhejiangxiaomai referenced this pull request in zhejiangxiaomai/velox Apr 20, 2023
@rui-mo @zhejiangxiaomai
Remove Velox prefixes in Substrait proto files (#6)
53b3da3
jinchengchenghh pushed a commit to jinchengchenghh/velox that referenced this pull request Jun 13, 2023
@zhejiangxiaomai
Merge pull request oap-project#6 from liujiayi771/jiayi_unscaled_valu…
e17eac5 
…e_vector_func

rewrite sparksql unscaled_value to vector func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rui-mo