Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multiple signers for runtime transactions #1705

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jan 18, 2025

Sometimes a TX has multiple signers. In that case, we should show them all in the "from" field in the TX details, like this:

Solves:

image

Live sample here.

Depends on:

Sorry, something went wrong.

Copy link

github-actions bot commented Jan 18, 2025

Deployed to Cloudflare Pages

Latest commit: 98b7b0417538ba86eaed1d00e1bfd5d511593d6b
Status:🚫 Deploy failed!

@csillag csillag force-pushed the csillag/display-multi-signers branch from 6866a1a to d8952fc Compare January 18, 2025 03:39
@csillag csillag self-assigned this Jan 18, 2025
@csillag csillag force-pushed the csillag/display-multi-signers branch 3 times, most recently from 560bfe7 to 9471aa2 Compare January 21, 2025 07:50
@csillag csillag marked this pull request as ready for review January 21, 2025 07:52
@csillag csillag force-pushed the csillag/display-multi-signers branch from 9471aa2 to 7596be3 Compare January 21, 2025 10:47
src/app/components/Account/ContractCreatorInfo.tsx Outdated Show resolved Hide resolved
.changelog/1705.trivial.md Outdated Show resolved Hide resolved
@csillag csillag requested a review from lukaw3d January 21, 2025 14:04
@csillag csillag force-pushed the csillag/display-multi-signers branch from 7596be3 to 2b52878 Compare January 21, 2025 14:36
For now, we also want to be compatible with the previous
versions of the API, so besides `tx.signers[]``, we
will also look at `tx.sender_0` and `tx.sender_0_eth`.
@csillag csillag force-pushed the csillag/display-multi-signers branch from e144310 to 98b7b04 Compare January 21, 2025 19:03
@csillag csillag enabled auto-merge January 21, 2025 19:03
@csillag csillag merged commit a3783ec into master Jan 21, 2025
6 of 7 checks passed
@csillag csillag deleted the csillag/display-multi-signers branch January 21, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants