Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display link to proposer in consensus block data #1706

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jan 18, 2025

When displaying consensus block details, we should also include a link to the validator that has proposed the block.
Other explorers do that, too.

image

Please note that this data has been already been displayed in the latest block list, like this:

image

It was only missing from the individual block detail pages, because it was not served by the backend, but that limitation is now gone, so we can display it.

Depends on:

Copy link

github-actions bot commented Jan 18, 2025

Deployed to Cloudflare Pages

Latest commit: b34f55c446b9a9a1ad96d56da6a30316812928bc
Status:✅ Deploy successful!
Preview URL: https://744f8516.oasis-explorer.pages.dev
Alias: https://pr-1706.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/show-consensus-block-proposer-in-details branch from 234a3e0 to 5855052 Compare January 18, 2025 14:56
@csillag csillag marked this pull request as ready for review January 18, 2025 14:57
@csillag csillag marked this pull request as draft January 18, 2025 14:58
@csillag csillag changed the title Display link to proposer in consensus block details Display link to proposer in consensus block data Jan 20, 2025
@csillag csillag self-assigned this Jan 20, 2025
@csillag csillag force-pushed the csillag/show-consensus-block-proposer-in-details branch 2 times, most recently from 1d7b5fc to 5f48092 Compare January 21, 2025 08:02
@csillag
Copy link
Contributor Author

csillag commented Jan 21, 2025

Design review from @donouwens:

This one looks good to me, great shout. Thanks!

@csillag csillag marked this pull request as ready for review January 21, 2025 08:28
@csillag csillag force-pushed the csillag/show-consensus-block-proposer-in-details branch from 5f48092 to acfcf8d Compare January 21, 2025 10:47
@csillag csillag force-pushed the csillag/show-consensus-block-proposer-in-details branch from acfcf8d to b34f55c Compare January 21, 2025 19:06
@csillag csillag merged commit 96b8a34 into master Jan 23, 2025
8 checks passed
@csillag csillag deleted the csillag/show-consensus-block-proposer-in-details branch January 23, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants