storage: handle NULL NFT owner #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
force-pushed
the
pro-wh/bugfix/nullowner
branch
from
2dd2639 to
48bc254
Compare
mitjat
approved these changes
Nov 22, 2023
| @@ -1579,8 +1579,8 @@ func (c *StorageClient) RuntimeEVMNFTs(ctx context.Context, limit *uint64, offse | |||
| var contractAddrContextVersion int | |||
| var contractAddrData []byte | |||
| var tokenType sql.NullInt32 | |||
| var ownerAddrContextIdentifier string | |||
| var ownerAddrContextVersion int | |||
| var ownerAddrContextIdentifier *string | |||
There was a problem hiding this comment.
Let's add a short inline comment here explaining why this is nullable.
There was a problem hiding this comment.
ya
oo come to think of it we should use if nft.Owner != nil instead
Andrew7234
approved these changes
Nov 22, 2023
pro-wh
force-pushed
the
pro-wh/bugfix/nullowner
branch
from
48bc254 to
5b876a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we only set owner on transfers, so when we see e.g. Approval, we can add an NFT to the db without setting an owner (hm, but anyway). prevent the storage glue from breaking (attempts to scan NULL into owner address context identifier string) when viewing these entries