Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key-manager: new unsecret state key #1504

Merged
merged 2 commits into from
Feb 26, 2019
Merged

key-manager: new unsecret state key #1504

merged 2 commits into from
Feb 26, 2019

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Feb 22, 2019

blocks https://github.com/oasislabs/runtime-ethereum/issues/606

The plan here:

  1. Make it possible to configure the set of keys to use for the key manager.
  2. Reprovision a new set of explicitly unsecret keys to use by default.
  3. Configure production to use the old keys.

image

@pro-wh pro-wh added the c:key management Category: key management label Feb 22, 2019
@Yawning
Copy link
Contributor

Yawning commented Feb 22, 2019

The approach looks reasonable enough to me. Especially for placeholders, the MRAE symmetric key can be anything as long as it's the right size.

@pro-wh pro-wh force-pushed the pro-wh/feature/kmrekey branch from 0165279 to 136210e Compare February 22, 2019 23:27
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #1504 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
- Coverage    54.4%   54.37%   -0.03%     
==========================================
  Files         160      160              
  Lines       14371    14371              
==========================================
- Hits         7818     7814       -4     
- Misses       5801     5804       +3     
- Partials      752      753       +1
Impacted Files Coverage Δ
go/scheduler/alg/greedy_subgraphs_scheduler.go 84.21% <0%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21abd9...136210e. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #1504 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
- Coverage   55.62%   55.49%   -0.13%     
==========================================
  Files         161      161              
  Lines       14376    14376              
==========================================
- Hits         7996     7978      -18     
- Misses       5605     5624      +19     
+ Partials      775      774       -1
Impacted Files Coverage Δ
go/client/client.go 59.42% <0%> (-8.7%) ⬇️
go/common/node/node.go 20.28% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215b65c...e9730f6. Read the comment docs.

@pro-wh pro-wh force-pushed the pro-wh/feature/kmrekey branch 3 times, most recently from a5fe77e to ec1a223 Compare February 25, 2019 23:30
@pro-wh pro-wh changed the title [wip] key-manager: new unsecret state key key-manager: new unsecret state key Feb 26, 2019
@pro-wh pro-wh force-pushed the pro-wh/feature/kmrekey branch from 1ef6c43 to 1b5410e Compare February 26, 2019 02:21
@pro-wh pro-wh force-pushed the pro-wh/feature/kmrekey branch from 1b5410e to e9730f6 Compare February 26, 2019 19:15
@pro-wh
Copy link
Contributor Author

pro-wh commented Feb 26, 2019

Thanks for the review. Gonna rebase for the gx fixes. Let's see if CI detects any regressions, with the default configuration.

@pro-wh pro-wh merged commit f921dec into master Feb 26, 2019
@pro-wh pro-wh deleted the pro-wh/feature/kmrekey branch February 26, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:key management Category: key management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants