-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
key-manager: new unsecret state key #1504
Conversation
The approach looks reasonable enough to me. Especially for placeholders, the MRAE symmetric key can be anything as long as it's the right size. |
0165279
to
136210e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
- Coverage 54.4% 54.37% -0.03%
==========================================
Files 160 160
Lines 14371 14371
==========================================
- Hits 7818 7814 -4
- Misses 5801 5804 +3
- Partials 752 753 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
- Coverage 55.62% 55.49% -0.13%
==========================================
Files 161 161
Lines 14376 14376
==========================================
- Hits 7996 7978 -18
- Misses 5605 5624 +19
+ Partials 775 774 -1
Continue to review full report at Codecov.
|
a5fe77e
to
ec1a223
Compare
1ef6c43
to
1b5410e
Compare
1b5410e
to
e9730f6
Compare
Thanks for the review. Gonna rebase for the gx fixes. Let's see if CI detects any regressions, with the default configuration. |
blocks https://github.com/oasislabs/runtime-ethereum/issues/606
The plan here: