Improve news fragment file name parsing #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version uses category as the reference point to later infer the issue number and counter value. As a consequence, it will return (None, None, None) if the base name doesn't contain a valid category. The new parser allows using file names like '123.feature.1.ext' which are convenient when one wants to use an appropriate extension (e.g. rst, md) to enable syntax highlighting.
tjanez
force-pushed
the
improve-parsing
branch
from
9e46a6a to
3623bd4
Compare
|
Also submitted upstream as twisted#173. |
tjanez
added a commit
to oasisprotocol/oasis-core
that referenced
this pull request
Jan 7, 2020
Document the (optional) .<COUNTER> part which allows one to include multiple Change Log fragments for a single issue or pull request. This towncrier feature was added in oasisprotocol/towncrier#2.
tjanez
added a commit
to oasisprotocol/oasis-core
that referenced
this pull request
Jan 7, 2020
Document the (optional) .<COUNTER> part which allows one to include multiple Change Log fragments for a single issue or pull request. This towncrier feature was added in oasisprotocol/towncrier#2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version uses category as the reference point to later infer the issue number and counter value.
As a consequence, it will return
(None, None, None)if the base name doesn't contain a valid category.The new parser allows using file names like
123.feature.1.extwhich are convenient when one wants to use an appropriate extension (e.g.rst,md) to enable syntax highlighting.Closes #1.