chore(deps): Updated to ginkgo v2

[kvanzuijlen]

Description

Updated ginkgo to v2

Motivation and Context

Ginkgo was outdated

How Has This Been Tested?

Checklist:

Ran tests locally.

• My change requires a change to the documentation or CHANGELOG.
• I have updated the documentation/CHANGELOG accordingly.
• I have created a feature (non-master) branch for my PR.
• I have written tests for my code changes.

I don't think this change requires a changelog entry since only _test.go files were changed

[JoelSpeed]

Changes look good, but somehow it's broken the redis tests so will need some investigation as to why those are broken now

[kvanzuijlen]

I'll have a look this evening

[kvanzuijlen]

@tuunit any idea? I've been going around in circles for a couple of hours. A fresh pair of (more experienced) eyes would help.

[JoelSpeed]

Currently showing

=== RUN   TestBasicSuite
Ginkgo detected an issue with your spec structure
AfterSuite(func() {
/home/runner/work/oauth2-proxy/oauth2-proxy/pkg/authentication/basic/htpasswd_test.go:104
  It looks like you are trying to add a [AfterSuite] node within a container
  node.

  AfterSuite can only be called at the top level.

  Learn more at:
  http://onsi.github.io/ginkgo/#suite-setup-and-cleanup-beforesuite-and-aftersuite

FAIL	github.com/oauth2-proxy/oauth2-proxy/v7/pkg/authentication/basic	0.020s

Which looks like it should be fairly straightforward, AfterSuite cannot be nested inside another container

[JoelSpeed]

oauth2-proxy/pkg/authentication/basic/htpasswd_test.go

Line 104 in a524c1f

AfterSuite(func() {

Should be AfterEach not AfterSuite

[tuunit]

@kvanzuijlen @JoelSpeed I fixed the Ginkgo issues :)

[tuunit]

oauth2-proxy/pkg/authentication/basic/htpasswd_test.go

Line 104 in a524c1f

AfterSuite(func() {

Should be AfterEach not AfterSuite

Indeed this was one of the issues. Ginkgo v1 didn't really enforce that AfterSuite can only be defined outside of the spec.

Furthermore, the execution order seems to have changed slightly which causes issues with the miniredis teardown. Therefore I separated the redis store tests into two specs. One for the miniredis configure with TLS and one without.

[github-actions]

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.