Implement Project and project-relative resolving #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let file = match cfgfile_folder.as_ref() { | ||
| Some(folder) => { | ||
| let file = folder.join("heradoc.toml"); | ||
| let content = fs::read_to_string(&file).expect(&format!("error reading config file at {:?}",file)); |
There was a problem hiding this comment.
A panic on user input?
| // 2. next to the input file | ||
| // 3. somewhere in the parent folders of the input file | ||
| let cfgfile_folder = match args.configfile.as_ref() { | ||
| Some(file) => Some(file.parent().expect("configfile passed as argument should point to a file and not the root-folder").to_owned()), |
There was a problem hiding this comment.
I see we have enough of these panic-unwraps above as well. Oh well, it might be time for a proper error with variants.
|
Thanks for the review! Currently, we always panic on user input regarding command line arguments. I created #138 to track moving to proper diagnostics during argument usage and config parsing / migration. However, that depends on #137, which will be quite a huge refactor. I don't want to block this PR on all of that mountain of work, especially because currently we just panic everywhere before we call into the generator. |
HeroicKatora
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.