Add negative filter tests #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u9g
commented
Aug 3, 2023
obi1kenobi
reviewed
Aug 3, 2023
trustfall_core/test_data/tests/valid_queries/fold_count_filter_eq.graphql.ron
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,19 @@ | |||
| TestGraphQLQuery ( | |||
| // We use a negative number as a filter to ensure that we properly handle the negative number case in get_max_fold_count_limit. | |||
There was a problem hiding this comment.
A few issues here:
- This line is too long. We don't currently have a linter set up, but please try to keep lines below 100 chars in all files to make sure they are readable.
- The comment references implementation details that may change and that ultimately aren't important. The test ensures that comparisons with negative numbers on count work in general, and would catch any failures even if they aren't in
get_max_fold_count_limit(). I wouldn't name that function or any other implementation details here. get_max_fold_count_limit()is code and a function. Please try to always put code in backticks and have function names followed by()to show they are functions.
There was a problem hiding this comment.
I spruced up the comments in the tests to look like this:
// Ensure that we properly handle negative numbers in a `not_one_of` filter on a folded edge's count.
I believe this is the longest one, and it's 101 characters including // so I think that's fine for now. I removed any mentions to internals in tests, good call.
Co-authored-by: Predrag Gruevski <[email protected]>
…ustfall into add-negative-filter-tests
obi1kenobi
reviewed
Aug 4, 2023
Co-authored-by: Predrag Gruevski <[email protected]>
obi1kenobi
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.