-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change primary name for UBERON:2000088 #1461
Comments
@wdahdul are you Ok to make this edit (in the phenoscape-ext module)? |
Do we get any useful generalization out of the two subclasses in Uberon? @hdrabkin is this for annotation or ontology axiomatization? |
The latter. If I want to make a logical def for a requested term yolk sac layer development. |
Thanks for linking the tracker items! I think we should make the change straight away, and we should also add taxon constraints and make sure the definition is suitably generalized. @sabrinatoro provided some links here: Also, e.g: Structure of the Yolk Syncytial Layer in Teleostei and Analogous |
@cmungall Would you add two taxon constraints in this case? e.g., 1) only_in_taxon some 'Vertebrata ' for Teleostei, Myxini, Chondrichthyes, and Lepisosteiformes, and 2) only_in_taxon some Cephalopoda |
But from saying only in taxon 1, could you also then say 'only in taxon 2'? Sounds contradictory. |
I would treat this as a union. Seems like an odd union though. Are there meaningful similarities between cephalopod and fish here? |
YSL, I-YSL, and E-YSL are terms in ZFA as well. Is it important to have consistency in term naming across these ontologies? Not sure if our anatomy editors would want to make that change. There are other terms handled in a similar way, at least in ZFA, having the abbreviated form as the primary term name when the community uses that format predominantly. Also, I believe it would be yolk syncytial layer, rather than yolk sac layer? I am assuming those two terms are referring to the same thing... |
@doughowe - see the linked ticket in ZFA tracker above. Standard ontology naming conventions are to spell out abbreviations in the primary name. Tools can still choose to use an abbreviation |
Stellar..looks like you guys are at least a day ahead of me! |
on second thoughts for TCs I think we should be conservative and only add negative constraints. Really we should have an ontology class somewhere for "mereoblastic cleavage" and add some TCs there. This could be a subclass of GO:0040016 embryonic cleavage, or of UBERON:0000107 cleavage stage. The uberon YSL would then be an output of this and inherit it's TCs.. |
The primary term name of UBERON:2000088 is YSL with an exact synonym of yolk sac layer. Could we get the primary name and synonym swapped so yolk sac layer is the term name and YSL is the synonym? The primary term name should be spelled out.
Two other term might also need to be changed similarly
E-YSL UBERON_2000309
I-YSL UBERON:2000712
The text was updated successfully, but these errors were encountered: