fix: improve performance for checking for configured model providers #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
force-pushed
the
better-model-provider-checks
branch
from
9ca1b5c to
e798ac2
Compare
This change simplifies the process for checking for configured model providers. When listing model providers, instead of making a call to reveal each credential, this change will make one call to list credentials. A side effect is that empty environment variables are not treated as "configured" while there were not previously. Care is taken to remove empty environment variables from the credential before saving it. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
better-model-provider-checks
branch
from
e798ac2 to
d841401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the process for checking for configured model providers. When listing model providers, instead of making a call to reveal each credential, this change will make one call to list credentials.
A side effect is that empty environment variables are not treated as "configured" while there were not previously. Care is taken to remove empty environment variables from the credential before saving it.