Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user tools to the top & toast on successful tool addition #839

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: user tools to the top & toast on successful tool addition #839

merged 2 commits into from
Dec 13, 2024

Conversation

ivyjeong13
Copy link
Contributor

@ivyjeong13 ivyjeong13 commented Dec 13, 2024 •
edited
Loading

Addresses #481.

Screenshot 2024-12-13 at 11 51 35 AM
  • creates toast when adding tool is successful
  • user created tools is at top

Update:

  • green checkmark for toast.success
Screenshot 2024-12-13 at 12 45 31 PM

njhale
njhale approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: This is called a "toast"

nit: might be nice for the checkmark to be green to intensify the "pat on the back" effect.

@ivyjeong13
Copy link
Contributor Author

TIL: This is called a "toast"

nit: might be nice for the checkmark to be green to intensify the "pat on the back" effect.

Will get that checkmark green!

@ivyjeong13 ivyjeong13 merged commit b6b0982 into obot-platform:main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale approved these changes

@ryanhopperlowe ryanhopperlowe Awaiting requested review from ryanhopperlowe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivyjeong13 @njhale