-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: model provider disable flows if not set & banner updates #949
Merged
ivyjeong13
merged 5 commits into
obot-platform:main
from
ivyjeong13:fix/model-provider-banner-and-ux-updates
Dec 18, 2024
Merged
fix: model provider disable flows if not set & banner updates #949
ivyjeong13
merged 5 commits into
obot-platform:main
from
ivyjeong13:fix/model-provider-banner-and-ux-updates
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivyjeong13
force-pushed
the
fix/model-provider-banner-and-ux-updates
branch
4 times, most recently
from
December 18, 2024 17:25
72d61ee
to
b0cbfb5
Compare
ivyjeong13
commented
Dec 18, 2024
ivyjeong13
requested review from
ryanhopperlowe,
njhale,
StrongMonkey and
g-linville
December 18, 2024 17:29
ivyjeong13
force-pushed
the
fix/model-provider-banner-and-ux-updates
branch
2 times, most recently
from
December 18, 2024 18:08
724c267
to
5e66716
Compare
ivyjeong13
force-pushed
the
fix/model-provider-banner-and-ux-updates
branch
from
December 18, 2024 20:08
5e66716
to
16a9f06
Compare
ryanhopperlowe
requested changes
Dec 18, 2024
ui/admin/app/components/model-providers/ModelProviderContext.tsx
Outdated
Show resolved
Hide resolved
ryanhopperlowe
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments but LOVE the new look
ivyjeong13
force-pushed
the
fix/model-provider-banner-and-ux-updates
branch
from
December 18, 2024 21:51
821bc1a
to
6f8fda5
Compare
ryanhopperlowe
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all set. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #934
Screen.Recording.2024-12-18.at.12.05.55.PM.mov