Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments showing example deploy fields. #18

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

mcglincy
Copy link
Contributor

@mcglincy mcglincy commented Jan 10, 2024

Part of observablehq/framework#496.

This time in the right file, and referring to "Observable Cloud".

// If deploying your project to Observable Cloud, you'll need a deploy property. E.g.,
// deploy: {
// workspace: "my-observablehq-workspace",
// project: "my-project-slug"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use the word "slug" anywhere user facing yet, at least commonly. I don't think it is widely known word, but maybe it's clear from context? I don't have a better word, so unless someone can come up with a better thing to put here I'm fine merging it, but I wanted to call it out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also wrestling with expressing this in the config.md text. My WIP wording there:

Specifies the target Observable workspace (without @ symbol) and the project short URL name (or "slug", similar to setting the URL for an Observable notebook).

@@ -1,6 +1,11 @@
export default {
// Config options documentation: https://cli.observablehq.com/config
title: "{{ projectTitle }}",
// If deploying your project to Observable Cloud, you'll need a deploy property. E.g.,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the documentation mentions Observable platform

Copy link
Member

@mbostock mbostock Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still TBD but the latest homepage drafts I have seen use “Observable Cloud”.

@mcglincy
Copy link
Contributor Author

Will merge this with language as-is; happy to re-edit if we change from "Observable Cloud" to something else.

@mcglincy mcglincy merged commit e17e058 into main Jan 11, 2024
@mcglincy mcglincy deleted the mcglincy/deploy-comments branch January 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants