Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template changes #21

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Template changes #21

merged 8 commits into from
Jan 12, 2024

Conversation

cinxmo
Copy link
Contributor

@cinxmo cinxmo commented Jan 11, 2024 •
edited
Loading

Changes:

  • add .env to .gitignore
  • change to use resize from the dash lib
  • more descriptive home page
  • include a report example

@cinxmo cinxmo force-pushed the cindy/template-changes branch from c18d686 to a1ee2a5 Compare January 11, 2024 17:37
trebor
trebor suggested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@trebor trebor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but we should remove the vestigial resize code. :)

template/docs/example-dashboard.md.tmpl Show resolved Hide resolved
template/docs/data/launchHistory.json.tmpl Outdated Show resolved Hide resolved
@cinxmo cinxmo force-pushed the cindy/template-changes branch from a1ee2a5 to 0126446 Compare January 12, 2024 00:18
@cinxmo cinxmo marked this pull request as ready for review January 12, 2024 00:21
@cinxmo cinxmo requested a review from trebor January 12, 2024 00:21
trebor
trebor suggested changes Jan 12, 2024
View reviewed changes
template/docs/example-report.md.tmpl Show resolved Hide resolved
template/docs/example-report.md.tmpl Show resolved Hide resolved
template/docs/index.md.tmpl Show resolved Hide resolved
@cinxmo cinxmo requested a review from trebor January 12, 2024 01:21
trebor
trebor approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@trebor trebor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. you might want to reduce the hight of the chart, but tots not a big deal!

@cinxmo
Copy link
Contributor Author

cinxmo commented Jan 12, 2024

@trebor updated!
Screenshot 2024-01-11 at 6 17 30 PM

@cinxmo cinxmo merged commit d6503c8 into main Jan 12, 2024
@cinxmo cinxmo deleted the cindy/template-changes branch January 12, 2024 02:19
@cinxmo cinxmo mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trebor trebor trebor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cinxmo @trebor