Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edits #29

Merged
merged 1 commit into from
Jan 12, 2024
Merged

edits #29

merged 1 commit into from
Jan 12, 2024

Conversation

mbostock
Copy link
Member

Screenshot 2024-01-12 at 12 54 31 PM Screenshot 2024-01-12 at 12 54 36 PM Screenshot 2024-01-12 at 12 54 41 PM

@mbostock mbostock requested review from trebor and cinxmo January 12, 2024 20:54
cinxmo
cinxmo reviewed Jan 12, 2024
View reviewed changes
template/.gitignore.tmpl
node_modules/
yarn-error.log
.env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbostock why do we not want to include .env?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it’s not used by any of the examples. It’s a convention used by dotenv; it isn’t a universal concept.

cinxmo
cinxmo reviewed Jan 12, 2024
View reviewed changes
template/docs/index.md.tmpl
- [Primary Mortgage Market Survey](https://cli-examples.observablehq.com/pmms/)
## More examples

See the [Observable CLI documentation](https://cli.observablehq.com/) for more documentation and examples!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we updating the CLI docs with a link to examples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, the CLI docs need to link to the examples. That’s how people will find them.

trebor
trebor approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@trebor trebor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great, thanks!

@mbostock mbostock merged commit 6fe2c4c into main Jan 12, 2024
@mbostock mbostock deleted the mbostock/edits branch January 12, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trebor trebor trebor approved these changes

@cinxmo cinxmo cinxmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbostock @trebor @cinxmo