Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated deploy.json does not pass prettier #381

Closed
pstuffa opened this issue Dec 13, 2023 · 0 comments · Fixed by #433
Closed

Generated deploy.json does not pass prettier #381

pstuffa opened this issue Dec 13, 2023 · 0 comments · Fixed by #433
Assignees
@mbostock
Labels
bug Something isn’t working

Comments

@pstuffa
Copy link
Contributor

pstuffa commented Dec 13, 2023

When I was using observable deploy, the generated deploy.json failed the prettier tests for my PR. It's missing a final newline. We should add this in so it passes tests by default.
@pstuffa pstuffa added the bug Something isn’t working label Dec 13, 2023
@mbostock mbostock added test Related to automated testing bug Something isn’t working and removed bug Something isn’t working test Related to automated testing labels Dec 22, 2023
@mbostock mbostock changed the title deploy.json fails prettier tests Generated deploy.json does not pass prettier Dec 22, 2023
@mbostock mbostock self-assigned this Jan 3, 2024
mbostock added a commit that referenced this issue Jan 3, 2024
@mbostock
fix #381; trailing newline for deploy.json
5c1633c
@mbostock mbostock mentioned this issue Jan 3, 2024
Merged
mbostock added a commit that referenced this issue Jan 3, 2024
@mbostock
fix #381; trailing newline for deploy.json (#433)
0a484a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

trailing newline for deploy.json observablehq/framework
2 participants
@mbostock @pstuffa