Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plot component to create #534

Closed
trebor opened this issue Jan 12, 2024 · 2 comments · Fixed by #574
Closed

add plot component to create #534

trebor opened this issue Jan 12, 2024 · 2 comments · Fixed by #574
Labels
enhancement New feature or request

Comments

@trebor
Copy link
Contributor

trebor commented Jan 12, 2024

create a plot component that is used in the create to show how components work.

@trebor trebor added the enhancement New feature or request label Jan 12, 2024
@Fil
Copy link
Contributor

Fil commented Jan 13, 2024

I'm a bit weary of adding a layer of abstraction on top of Plot in general—Plot is supposed to be concise and expressive enough for most use cases. There are a few cases though where it's proven to be very helpful. For example for a calendar. We have two versions: one based on Plot, the other on D3. In both cases it's difficult to make "by hand" so a component is helpful when compared to "raw" Plot or D3.

@mbostock
Copy link
Member

This is a demonstration of how components/imports work, not an abstraction on top of Plot. This is simply about pulling JavaScript code out of Markdown and into a standalone JavaScript module that you can import across multiple pages.

@mbostock mbostock added this to the General availability milestone Jan 16, 2024
Fil added a commit that referenced this issue Jan 20, 2024
* remove the bignumber component

closes #534
related #248
@Fil Fil closed this as completed in #574 Jan 20, 2024
Fil added a commit that referenced this issue Jan 20, 2024
* * add a Plot component
* remove the bignumber component

closes #534
related #248

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants