-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A better error message when the specified style is not found #681
Comments
ok I've tried several things (like checking that the source is an actual file and not a directory) — however they only add complexity. What we want here is only to let the user to know that this problem is due to the style option, which is not obvious from the current message.
A possibility might be to change the message slightly into:
We could also catch the error and then add one line of log to say |
related: #525 |
This is crashing build specifically, right? Does it show up when you run "yarn build", or only deploy? This provides more evidence that we should be separating build and deploy. |
yes, it crashes the build. In this case it's a good thing that the build errors, but the error message was unclear and it took me a moment to find why it was erroring. |
To clarify the issue description: it’s expected that the build crashes if you reference a stylesheet that does not exist (including the empty string); but we want a better error message when this happens. So this is not a bug (the crashing is desired), but we should enhance the error message. |
…tion (#766) * just a log that clarifies that this bundle emanates from the style option closes #681 * style Co-authored-by: Mike Bostock <[email protected]> --------- Co-authored-by: Mike Bostock <[email protected]>
No description provided.
The text was updated successfully, but these errors were encountered: