TypeScript #1632
Merged
TypeScript #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
reviewed
Sep 3, 2024
Fil
reviewed
Sep 3, 2024
Fil
approved these changes
Sep 3, 2024
|
The next release is going to be HUGE! |
|
oh my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reboot of #129. Fixes #79.
TODO
```tsfenced code blocks```tsxfenced code blocks.tsmodules.tsxmodulesTypeScript in inline expressions(not supported)Unlike #129, I expressly avoided allowing TypeScript in inline expressions, which allows us to avoid running the esbuild transform on them, and in turn avoids the problem of esbuild converting expressions to expression statements and then losing implicit display. Not also that there is no implicit display in
```tsblocks. I think this is an acceptable tradeoff, at least for now, as you get the primary benefits of TypeScript modules and TypeScript fenced code blocks and only if you explicitly opt-in to using TypeScript.Also unlike #129, this only allows TypeScript to be imported with the
.js, as we do for.jsx. This is the recommended practice because it means the import path doesn’t change after transpilation.