Accept path?search and path#hash in the pager and the sidebar. #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #197. The pager now supports paths containing ?search #hash. However when there are several of them, only the first page is taken into account by the pager, and a warning is logged. The sidebar opens and highlights these pages as necessary.
mbostock
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pager now supports paths containing ?search #hash. However when there are several of them, only the first page is taken into account by the pager, and a warning is logged.
The sidebar opens and highlights these pages as necessary.
closes #197.
(I don't think we can do much better if we want to keep the logic server-side.)