Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable footer #450

Merged
merged 2 commits into from
Jan 8, 2024
Merged

configurable footer #450

merged 2 commits into from
Jan 8, 2024

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jan 8, 2024

closes #55

@Fil Fil requested review from mbostock and cinxmo January 8, 2024 14:29
mbostock
mbostock requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the footer be nullable, too? I guess you could always set it to an empty string, but if it’s null we could avoid emitting the <div> in renderFooter, too.

Just missing some coercion…

src/config.ts Show resolved Hide resolved
@Fil
Copy link
Contributor Author

Fil commented Jan 8, 2024

Do you think we should consider null to not create the div, and "" to create an empty div? I went for the simpler where null is not supported, and "" does not create the div.

@Fil Fil merged commit db6a7d5 into main Jan 8, 2024
2 checks passed
@Fil Fil deleted the fil/footer branch January 8, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

@cinxmo cinxmo Awaiting requested review from cinxmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable footer message
2 participants
@Fil @mbostock